linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: linux-trace-devel@vger.kernel.org, y.karadz@gmail.com,
	troyengel@gmail.com, Slavomir Kaslev <kaslevs@vmware.com>
Subject: Re: [PATCH v2 3/8] kernel-shark: Add logic for the plugins search path
Date: Fri, 3 May 2019 19:05:57 -0400	[thread overview]
Message-ID: <20190503190557.6e36e59a@gandalf.local.home> (raw)
In-Reply-To: <20190502124009.32208-4-ykaradzhov@vmware.com>

On Thu,  2 May 2019 15:40:04 +0300
Yordan Karadzhov <ykaradzhov@vmware.com> wrote:

> If the application has not been started from its installation location
> and the the directory
> 
>  app_file_path + "../../kernel-shark/lib"
> 
> exists, all build-in plugins will be loaded from this directory. In any
> other case all build-in plugins will be loaded from
> 
> _INSTALL_PREFIX/lib/kshark/plugins/
> 
> Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> ---
>  kernel-shark/src/KsUtils.cpp            | 40 ++++++++++++++++++-------
>  kernel-shark/src/KsUtils.hpp            |  2 ++
>  kernel-shark/src/plugins/CMakeLists.txt |  2 +-
>  3 files changed, 32 insertions(+), 12 deletions(-)
> 

Hi Yordan,

After applying this patch, kernelshark's behavior for loading trace.dat
changed. It no longer looks for the file in the current directory. If I
run:

 # trace-cmd record -e sched_switch sleep 1
 # kernelshark

It loads without loading the produced trace.dat.

If I run:

 # kernelshark trace.dat

I get an error message stating:

 "Unable to find file trace.dat"

-- Steve

  reply	other threads:[~2019-05-03 23:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 12:40 [PATCH v2 0/8] Modifications needed for KS 1.0 Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 1/8] kernel-shark: Add INSTALL PREFIX to the Cmake-generated header file Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 2/8] kernel-shark: Add logic for the initial path of Open-File dialogs Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 3/8] kernel-shark: Add logic for the plugins search path Yordan Karadzhov
2019-05-03 23:05   ` Steven Rostedt [this message]
2019-05-04  8:27     ` Yordan Karadzhov (VMware)
2019-05-04 11:31       ` Steven Rostedt
2019-05-04  8:28     ` Yordan Karadzhov (VMware)
2019-05-02 12:40 ` [PATCH v2 4/8] kernel-shark: Remove the definition of KS_DIR Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 5/8] kernel-shark: Remember the paths used by the Open-File dialogs Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 6/8] kernel-shark: Add logic for selecting the trace-cmd executable used Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 7/8] kernel-shark: Remove hard-coded install paths for libraries and plugins Yordan Karadzhov
2019-05-02 12:40 ` [PATCH v2 8/8] kernel-shark: Use XDG compliant path when saving cached data Yordan Karadzhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503190557.6e36e59a@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=troyengel@gmail.com \
    --cc=y.karadz@gmail.com \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).