From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=bhO7=TL=vger.kernel.org=linux-trace-devel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,
	USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 49C91C04AB1
	for <linux-trace-devel@archiver.kernel.org>; Sat, 11 May 2019 06:02:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 0F2CE2182B
	for <linux-trace-devel@archiver.kernel.org>; Sat, 11 May 2019 06:02:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1557554527;
	bh=p/HRiT9yqHlg2V7XNH8WpqZb2zm5DrER+cqskPbJ7+s=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=nLvlmtFIJuN5F91IY5pYwGi1Os/7BpBDkNW3ghU2SgRQRA0IM09onbHmzGnXvglQj
	 KJX/m5kJ3o5Dwn/M6KVcBZjmKMcvKfL2uv/1m3GErPVMRGoHL+Nr+qL5Pnz9EQdigY
	 YEU0UcsLbzou7voj9ji3ITYB4GpfxAqR4C4DR8xM=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725990AbfEKGCG (ORCPT
        <rfc822;linux-trace-devel@archiver.kernel.org>);
        Sat, 11 May 2019 02:02:06 -0400
Received: from mail.kernel.org ([198.145.29.99]:54554 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725874AbfEKGCG (ORCPT
        <rfc822;linux-trace-devel@vger.kernel.org>);
        Sat, 11 May 2019 02:02:06 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C61012173B;
        Sat, 11 May 2019 06:02:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1557554525;
        bh=p/HRiT9yqHlg2V7XNH8WpqZb2zm5DrER+cqskPbJ7+s=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ktm0kz52FhtprAmfDKfRf0+t/ACR967wBlZo/njpZyLTvdvQQcZE/JHEG0mPhwMnS
         fSPu28p3h+yTt9jEZ2bBD58kVUAHRLZfIuy79u26uItO5gMpvcOkRhorvGTs7CSDs1
         MdDsjOpnTitVkTfxOZTdc+qoCez/9OEhX6dWx0xE=
Date:   Sat, 11 May 2019 08:02:03 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Adrian Ratiu <adrian.ratiu@collabora.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        atish patra <atishp04@gmail.com>, bpf@vger.kernel.org,
        Brendan Gregg <bgregg@netflix.com>,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Daniel Colascione <dancol@google.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Dan Williams <dan.j.williams@intel.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        duyuchao <yuchao.du@unisoc.com>,
        Guenter Roeck <groeck@chromium.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Karim Yaghmour <karim.yaghmour@opersys.com>,
        Kees Cook <keescook@chromium.org>,
        "Cc: Android Kernel" <kernel-team@android.com>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        linux-trace-devel@vger.kernel.org,
        Manjo Raja Rao <linux@manojrajarao.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        =?utf-8?Q?Micha=C5=82?= Gregorczyk <michalgr@fb.com>,
        Michal Gregorczyk <michalgr@live.com>,
        Mohammad Husain <russoue@gmail.com>,
        Olof Johansson <olof@lixom.net>,
        Qais Yousef <qais.yousef@arm.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Shuah Khan <shuah@kernel.org>,
        Srinivas Ramana <sramana@codeaurora.org>,
        Tamir Carmeli <carmeli.tamir@gmail.com>,
        Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH 3/3] kheaders: Make it depend on sysfs
Message-ID: <20190511060203.GA18650@kroah.com>
References: <20190510210243.152808-1-joel@joelfernandes.org>
 <20190510210243.152808-4-joel@joelfernandes.org>
 <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-trace-devel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-trace-devel.vger.kernel.org>
X-Mailing-List: linux-trace-devel@vger.kernel.org

On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote:
> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> <joel@joelfernandes.org> wrote:
> >
> > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > depend on SYSFS as it makes no sense to enable this feature without it.
> 
> 
> And, it also makes no sense to break the feature by 1/3,
> then fix it by 3/3.
> 
> 
> Why don't you squash this?

I agree, this belongs in patch 1/3.