From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C933EC04AB1 for ; Sat, 11 May 2019 16:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AD8F2089E for ; Sat, 11 May 2019 16:17:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="qLq/xi5V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbfEKQRT (ORCPT ); Sat, 11 May 2019 12:17:19 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38292 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbfEKQRT (ORCPT ); Sat, 11 May 2019 12:17:19 -0400 Received: by mail-pg1-f194.google.com with SMTP id j26so4523729pgl.5 for ; Sat, 11 May 2019 09:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Odh+YMUmXqxxn2pUwWEKZYqwhsM/e7BZh99KpQUKonM=; b=qLq/xi5VaOmk5QBHpCipGArPVi3NegYyBubZ0l23k5Meagl/axkdmV0pJLKMnaBK6x 719v6LAMXaMXcOXzRKnSMK9Cse4PTZxL4W79PAR6oqtFAKiPyR4GJfPIg8Xf7+4STwCO 7DzTlF98i4slQDIv6HVl4kUQlCuvXNgpq5WCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Odh+YMUmXqxxn2pUwWEKZYqwhsM/e7BZh99KpQUKonM=; b=OQ/mDbj6kdJYrIxXBIjSYGH58JNE03YHs3D7tFWn3eNpayZuVS68BjxIl2pXWAdtdU xWT+g2P9TUYIycU6dvnN6+y2HulbMk1tyHto8rC+5NPTSVCpMu6/sgu8d/F+/mdT00/n wuiF5On4kkKedwqmpFaiQrjP9xRhbYOK2WHuTqQ3L+xor7M+28gYOK+FPnWLoZQ21UVA GVKnSGima2HW4KDKGB8Aq1Dy8JDvmgN0+i/sXxzjoP3f5rOofpkZoOxmWR4s4ZjwmSmR xzVrCdi15X6dlqCnffRIzYGUECFQqfWOlTP+9hfZWxrjWsTjcCwPB7TRuMNtXScLT99N 09sw== X-Gm-Message-State: APjAAAXgMOfCCRygcv6veKcBDau/4A2wxLRuZDu/ZbwIB+7yzNW4u3Wm +ur/oAihg3Kh0RvofhzbphVz6Q== X-Google-Smtp-Source: APXvYqxTiJcEcmzT7eLWCLJAaF3JSIaR+WNDPlhbqHsPuJXlNFt0am0ojnsERLBSkb1Ve0uNPXHBVg== X-Received: by 2002:a65:62c4:: with SMTP id m4mr21634116pgv.308.1557591438309; Sat, 11 May 2019 09:17:18 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id z187sm12253685pfb.132.2019.05.11.09.17.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 May 2019 09:17:16 -0700 (PDT) Date: Sat, 11 May 2019 12:17:14 -0400 From: Joel Fernandes To: Greg Kroah-Hartman Cc: Masahiro Yamada , Linux Kernel Mailing List , Adrian Ratiu , Alexei Starovoitov , Andrew Morton , atish patra , bpf@vger.kernel.org, Brendan Gregg , Brendan Gregg , Daniel Colascione , Daniel Borkmann , Dan Williams , Dietmar Eggemann , duyuchao , Guenter Roeck , Jonathan Corbet , Karim Yaghmour , Kees Cook , "Cc: Android Kernel" , "open list:DOCUMENTATION" , "open list:KERNEL SELFTEST FRAMEWORK" , linux-trace-devel@vger.kernel.org, Manjo Raja Rao , Masami Hiramatsu , =?utf-8?Q?Micha=C5=82?= Gregorczyk , Michal Gregorczyk , Mohammad Husain , Olof Johansson , Qais Yousef , Randy Dunlap , Steven Rostedt , Shuah Khan , Srinivas Ramana , Tamir Carmeli , Yonghong Song Subject: Re: [PATCH 3/3] kheaders: Make it depend on sysfs Message-ID: <20190511161714.GA179270@google.com> References: <20190510210243.152808-1-joel@joelfernandes.org> <20190510210243.152808-4-joel@joelfernandes.org> <20190511060203.GA18650@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190511060203.GA18650@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Sat, May 11, 2019 at 08:02:03AM +0200, Greg Kroah-Hartman wrote: > On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote: > > On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google) > > wrote: > > > > > > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it > > > depend on SYSFS as it makes no sense to enable this feature without it. > > > > > > And, it also makes no sense to break the feature by 1/3, > > then fix it by 3/3. > > > > > > Why don't you squash this? > > I agree, this belongs in patch 1/3. Fine with me. The reason I split it this way is I already had posted 1/3 recently for the driver tree [1], and I did not want to confuse Greg since he was in the process of picking it up [2]. Anyway, I can resend the series soon with 1/3 and 3/3 squashed unless anyone applying this is Ok with squashing it in their trees. thanks! [1] https://lore.kernel.org/patchwork/patch/1070005/ [2] https://lore.kernel.org/patchwork/patch/1070005/#1267273 thanks, - Joel