From: Steven Rostedt <rostedt@goodmis.org>
To: Ceco <tz.stoyanov@gmail.com>
Cc: Yordan Karadzhov <y.karadz@gmail.com>, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] trace-cmd: Implemented new API tracecmd_add_option_v()
Date: Mon, 17 Jun 2019 09:39:49 -0400 [thread overview]
Message-ID: <20190617093949.4d612c75@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN4ZwsZYCzjSGkyuu8r0ih-=7K8qG+TtQA33OxTfqbFjhA@mail.gmail.com>
On Mon, 17 Jun 2019 16:18:38 +0300
Ceco <tz.stoyanov@gmail.com> wrote:
> Hi Steven
>
> On Mon, Jun 17, 2019 at 4:06 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> ...
> >
> > Hmm, I think this is a bit overkill. I don't really see anything using
> > more than one or two data vectors. All I see would be at most a "count"
> > followed by a list of data, which is what I think you are using this
> > for.
> >
> > I rather wait to implement something like this when there's more of a
> > need for it. I don't believe this change really requires it.
> >
> > -- Steve
> >
>
> Actually, this patch is from the patch set (N 7):
> "trace-cmd: Timetamps sync between host and guest machines, relying
> on vsock events. "
> and I took it as-is. In timesync changes tracecmd_add_option_v() is
> used in similar way.
> That explains the tracecmd_append_options() API, which is used there.
>
>
Ah, that needed to be stated. Yeah, when taking a patch from another
series, make sure that the change log is updated too. Never expect that
the reviewer will know about any other series ;-)
-- Steve
next prev parent reply other threads:[~2019-06-17 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 11:52 [PATCH 0/2] Save tracee memory map into trace.dat file tz.stoyanov
2019-06-17 11:52 ` [PATCH 1/2] trace-cmd: Implemented new API tracecmd_add_option_v() tz.stoyanov
2019-06-17 13:06 ` Steven Rostedt
2019-06-17 13:18 ` Ceco
2019-06-17 13:39 ` Steven Rostedt [this message]
2019-06-17 11:52 ` [PATCH 2/2] trace-cmd: Save the tracee memory map into the trace.dat file tz.stoyanov
2019-06-17 13:37 ` Steven Rostedt
2019-06-17 14:12 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617093949.4d612c75@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).