linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: tz.stoyanov@gmail.com, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Do not free pages from the lookup table in struct cpu_data in case trace file is loaded.
Date: Tue, 25 Jun 2019 18:32:45 -0400	[thread overview]
Message-ID: <20190625183245.38d63750@gandalf.local.home> (raw)
In-Reply-To: <c456ec4152a3cce13e875666ad080b755a3d39fb.camel@sipsolutions.net>

On Wed, 19 Jun 2019 13:52:14 +0200
Johannes Berg <johannes@sipsolutions.net> wrote:

> Seems to work, more or less. I now see ~6.5 seconds which is slower than
> it was, and in particular comparing to just a revert (which was ~2
> seconds), but it's usable :-)

I'm totally confused. Unless it is a cache miss thing, the only thing
it did was add two branches that should basically follow the old path
with the revert.

Can you run perf comparing this patch against the revert and see where
the difference lies?

Thanks!

-- Steve

  reply	other threads:[~2019-06-25 22:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19 11:49 [PATCH] trace-cmd: Do not free pages from the lookup table in struct cpu_data in case trace file is loaded tz.stoyanov
2019-06-19 11:52 ` Johannes Berg
2019-06-25 22:32   ` Steven Rostedt [this message]
2019-06-26  6:51     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190625183245.38d63750@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=tz.stoyanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).