From: Greg Thelen <gthelen@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org, Greg Thelen <gthelen@google.com>
Subject: [PATCH] trace-cmd: remove ununsed knuth_hash*() routines
Date: Tue, 25 Jun 2019 23:01:01 -0700 [thread overview]
Message-ID: <20190626060101.220607-1-gthelen@google.com> (raw)
Neither knuth_hash16() nor knuth_hash() are used.
Delete them.
Signed-off-by: Greg Thelen <gthelen@google.com>
---
lib/trace-cmd/trace-filter-hash.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/lib/trace-cmd/trace-filter-hash.c b/lib/trace-cmd/trace-filter-hash.c
index 39b28790e0bc..c56628f69ff0 100644
--- a/lib/trace-cmd/trace-filter-hash.c
+++ b/lib/trace-cmd/trace-filter-hash.c
@@ -29,26 +29,6 @@ static inline uint8_t knuth_hash8(uint32_t val)
return UINT8_C(val) * UINT8_C(157);
}
-static inline uint16_t knuth_hash16(uint32_t val)
-{
- /*
- * Multiplicative hashing function.
- * Multiplication by the Prime number, closest to the golden
- * ratio of 2^16.
- */
- return UINT16_C(val) * UINT16_C(40507);
-}
-
-static inline uint32_t knuth_hash(uint32_t val)
-{
- /*
- * Multiplicative hashing function.
- * Multiplication by the Prime number, closest to the golden
- * ratio of 2^32.
- */
- return val * UINT32_C(2654435761);
-}
-
struct tracecmd_filter_id_item *
tracecmd_filter_id_find(struct tracecmd_filter_id *hash, int id)
{
--
2.22.0.410.gd8fdbe21b5-goog
next reply other threads:[~2019-06-26 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 6:01 Greg Thelen [this message]
2019-06-26 19:34 ` [PATCH] trace-cmd: remove ununsed knuth_hash*() routines Steven Rostedt
2019-06-27 15:40 ` Yordan Karadzhov (VMware)
2019-06-27 16:15 ` Steven Rostedt
2019-06-28 15:55 ` Greg Thelen
2019-06-29 6:27 ` [PATCH v2] " Greg Thelen
2019-07-01 12:23 ` Yordan Karadzhov (VMware)
2019-07-05 13:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626060101.220607-1-gthelen@google.com \
--to=gthelen@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).