From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: Greg Thelen <gthelen@google.com>, linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: remove ununsed knuth_hash*() routines
Date: Thu, 27 Jun 2019 12:15:42 -0400 [thread overview]
Message-ID: <20190627121542.2dc0d328@gandalf.local.home> (raw)
In-Reply-To: <550e11ae-1ac1-dbee-e88b-e62f63a6d032@gmail.com>
On Thu, 27 Jun 2019 18:40:27 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> Hi Greg,
>
> Thanks for the fix!
>
> I agree that we have to remove the unused hashing functions, but may I
> ask you to do a little bit of extra work here.
> I think that if we are going to keep only one hashing function this
> function can be called simply knuth_has (not knuth_has8).
Hi Yordan,
Small nit. I think you meant "knuth_hash" not "knuth_has", even though
I'm sure knuth has a lot ;-)
>
> Also the comment on top which refers to the TAOCP book must be modified
> stating that the original idea from the book (32 bit hash) was adapted
> in order to be used for small tables.
Ack.
-- Steve
next prev parent reply other threads:[~2019-06-27 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 6:01 [PATCH] trace-cmd: remove ununsed knuth_hash*() routines Greg Thelen
2019-06-26 19:34 ` Steven Rostedt
2019-06-27 15:40 ` Yordan Karadzhov (VMware)
2019-06-27 16:15 ` Steven Rostedt [this message]
2019-06-28 15:55 ` Greg Thelen
2019-06-29 6:27 ` [PATCH v2] " Greg Thelen
2019-07-01 12:23 ` Yordan Karadzhov (VMware)
2019-07-05 13:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627121542.2dc0d328@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gthelen@google.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).