linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
	"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 1/2] kernel-shark: Line up the table of the loaded Advanced filters
Date: Fri,  5 Jul 2019 17:10:30 +0300	[thread overview]
Message-ID: <20190705141031.20239-2-y.karadz@gmail.com> (raw)
In-Reply-To: <20190705141031.20239-1-y.karadz@gmail.com>

The Advanced filtering dialog shows a table of the already loaded filters.
The new line that is added at the end of the string breaks the alignment
of the last column of this tables.

Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
 kernel-shark/src/KsAdvFilteringDialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel-shark/src/KsAdvFilteringDialog.cpp b/kernel-shark/src/KsAdvFilteringDialog.cpp
index 1edf68b..6af1aea 100644
--- a/kernel-shark/src/KsAdvFilteringDialog.cpp
+++ b/kernel-shark/src/KsAdvFilteringDialog.cpp
@@ -216,7 +216,7 @@ void KsAdvFilteringDialog::_getFilters(struct kshark_context *kshark_ctx)
 			continue;
 
 		_filters.insert(events[i]->id,
-				QString("%1/%2:%3\n").arg(events[i]->system,
+				QString("%1/%2:%3").arg(events[i]->system,
 							  events[i]->name, str));
 
 		free(str);
-- 
2.20.1


  reply	other threads:[~2019-07-05 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 14:10 [PATCH 0/2] Fixes needed befor KS 1.0 Yordan Karadzhov (VMware)
2019-07-05 14:10 ` Yordan Karadzhov (VMware) [this message]
2019-07-05 14:10 ` [PATCH 2/2] kernel-shark: Separate the target instalation instructions Yordan Karadzhov (VMware)
2019-07-05 14:25 ` [PATCH 0/2] Fixes needed befor KS 1.0 Slavomir Kaslev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190705141031.20239-2-y.karadz@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).