linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Cc: Yordan Karadzhov <y.karadz@gmail.com>
Subject: [PATCH 2/2] kernel-shark: Set the DISPLAY environment for pkexec kshark-record
Date: Tue, 23 Jul 2019 18:50:46 -0400	[thread overview]
Message-ID: <20190723225238.859019956@goodmis.org> (raw)
In-Reply-To: 20190723225044.576298160@goodmis.org

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

When running a fresh install, I hit this:

 ERROR:  Capture process failed:
 Unknown errorqt.qpa.screen: QXcbConnection: Could not connect to display
 Could not connect to any X display.

This was due to pkexec not saving the DISPLAY environment variable. To solve
this, pass that variable as one of the environment variables to pkexec.

Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 kernel-shark/bin/kshark-su-record | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel-shark/bin/kshark-su-record b/kernel-shark/bin/kshark-su-record
index 7faff1cb3339..8c9fbd02a351 100755
--- a/kernel-shark/bin/kshark-su-record
+++ b/kernel-shark/bin/kshark-su-record
@@ -6,4 +6,4 @@ then
 fi
 
 THIS_DIR=`dirname $0`
-pkexec ${THIS_DIR}/kshark-record -o ${PWD}/trace.dat
+pkexec env DISPLAY=${DISPLAY} ${THIS_DIR}/kshark-record -o ${PWD}/trace.dat
-- 
2.20.1



  parent reply	other threads:[~2019-07-23 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 22:50 [PATCH 0/2] kernel-shark: Be more careful with kshark-su-record Steven Rostedt
2019-07-23 22:50 ` [PATCH 1/2] kernel-shark: Execute kshark-record from same dir as kshark-su-record Steven Rostedt
2019-07-25  9:01   ` Yordan Karadzhov (VMware)
2019-07-25 12:45     ` Steven Rostedt
2019-07-25 13:59       ` Yordan Karadzhov (VMware)
2019-07-25 14:00       ` Yordan Karadzhov (VMware)
2019-07-23 22:50 ` Steven Rostedt [this message]
2019-07-24 10:42   ` [PATCH 2/2] kernel-shark: Set the DISPLAY environment for pkexec kshark-record Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723225238.859019956@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).