From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69A6C7618B for ; Thu, 25 Jul 2019 12:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3F6F217F4 for ; Thu, 25 Jul 2019 12:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388889AbfGYMtf (ORCPT ); Thu, 25 Jul 2019 08:49:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:57532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389217AbfGYMtf (ORCPT ); Thu, 25 Jul 2019 08:49:35 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E5AF9217F4; Thu, 25 Jul 2019 12:49:33 +0000 (UTC) Date: Thu, 25 Jul 2019 08:49:32 -0400 From: Steven Rostedt To: Patrick McLean Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH] trace-cmd: Generate proper soname Message-ID: <20190725084932.43e05c27@gandalf.local.home> In-Reply-To: <20190725014808.3646716-1-chutzpah@gentoo.org> References: <20190725014808.3646716-1-chutzpah@gentoo.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 24 Jul 2019 18:48:08 -0700 Patrick McLean wrote: > From: Patrick McLean > > The previous soname patch was an earlier version that included the full > path to the build output as the soname (not sure how that happened). > This just uses the basename as the soname, so ld will be able to > properly find the library. Hi Patrick, You forgot to add the Signed-off-by, can you reply to this with one. Thanks. I can't add it without it. -- Steve > --- > scripts/utils.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/utils.mk b/scripts/utils.mk > index 9eb127d..98d7b3c 100644 > --- a/scripts/utils.mk > +++ b/scripts/utils.mk > @@ -54,7 +54,7 @@ do_build_static_lib = \ > > do_compile_shared_library = \ > ($(print_shared_lib_compile) \ > - $(CC) --shared $^ -Wl,-soname,$@ -o $@) > + $(CC) --shared $^ -Wl,-soname,$(@F) -o $@) > > do_compile_plugin_obj = \ > ($(print_plugin_obj_compile) \