From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 0/8] Separate trace-cmd and libtracecmd code
Date: Wed, 14 Aug 2019 11:47:00 +0300 [thread overview]
Message-ID: <20190814084712.28188-1-tz.stoyanov@gmail.com> (raw)
libtracecmd is a library, containing functions that can be
used without the trace-cmd application. However, some of the
functions declared as libtracecmd APIs in trace-cmd.h
depend on trace-cmd context. That causes a problem when
other application uses the library. The problem can be
observed when running kerneshark and there is a python
module, loaded by the python plugin - there is a bunch
of warnings.
To resolve the problem, implementations of all trace-cmd
independent functions are moved into libtracecmd. All
libtracecmd functions, that depend on trace-cmd context
are removed from the library and from trace-cmd.h file.
[
v2 changes:
- Added a new patch:
Move trace-cmd-local.h from the application to the library.
- Remove trace-output.c dependency of version.h. Moved FILE_VERSION_STRING
define from top Makefile to trace-cmd-local.h.
]
Tzvetomir Stoyanov (VMware) (8):
trace-cmd: Move trace-cmd-local.h from the application to the library
trace-cmd: Move trace-output.c into the library code
trace-cmd: Move trace-msg.c into the library.
trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd
trace-cmd: Move trace-cmd global variable "debug" to libtracecmd
trace-cmd: Move plog() function to libtracecmd.
trace-cmd: Move trace-cmd APIs from trace-cmd.h to trace-local.h
trace-cmd: Move tracecmd_stack_tracer_status() function to libtracecmd
Makefile | 3 -
include/trace-cmd/trace-cmd.h | 19 +-
.../include => include/trace-cmd}/trace-msg.h | 3 -
include/version.h | 5 -
lib/trace-cmd/Makefile | 2 +
.../trace-cmd}/include/trace-cmd-local.h | 7 +-
{tracecmd => lib/trace-cmd}/trace-msg.c | 4 +-
{tracecmd => lib/trace-cmd}/trace-output.c | 5 +-
lib/trace-cmd/trace-util.c | 162 ++++++++++++++++++
tracecmd/Makefile | 2 -
tracecmd/include/trace-local.h | 14 +-
tracecmd/trace-cmd.c | 3 -
tracecmd/trace-list.c | 2 +-
tracecmd/trace-listen.c | 77 ++-------
tracecmd/trace-read.c | 8 +-
tracecmd/trace-record.c | 8 +-
tracecmd/trace-stack.c | 56 +-----
17 files changed, 218 insertions(+), 162 deletions(-)
rename {tracecmd/include => include/trace-cmd}/trace-msg.h (79%)
rename {tracecmd => lib/trace-cmd}/include/trace-cmd-local.h (83%)
rename {tracecmd => lib/trace-cmd}/trace-msg.c (99%)
rename {tracecmd => lib/trace-cmd}/trace-output.c (99%)
--
2.21.0
next reply other threads:[~2019-08-14 8:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 8:47 Tzvetomir Stoyanov (VMware) [this message]
2019-08-14 8:47 ` [PATCH v2 1/8] trace-cmd: Move trace-cmd-local.h from the application to the library Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 2/8] trace-cmd: Move trace-output.c into the library code Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 3/8] trace-cmd: Move trace-msg.c into the library Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v2 4/8] trace-cmd: Move trace-cmd global variable "quiet" to libtracecmd Tzvetomir Stoyanov (VMware)
2019-08-28 19:59 ` Steven Rostedt
2019-08-29 11:39 ` Tzvetomir Stoyanov
2019-08-29 16:38 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 5/8] trace-cmd: Move trace-cmd global variable "debug" " Tzvetomir Stoyanov (VMware)
2019-08-28 20:01 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 6/8] trace-cmd: Move plog() function " Tzvetomir Stoyanov (VMware)
2019-08-28 20:15 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 7/8] trace-cmd: Move trace-cmd APIs from trace-cmd.h to trace-local.h Tzvetomir Stoyanov (VMware)
2019-08-28 20:17 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v2 8/8] trace-cmd: Move tracecmd_stack_tracer_status() function to libtracecmd Tzvetomir Stoyanov (VMware)
2019-08-28 20:21 ` Steven Rostedt
2019-09-03 12:24 ` Tzvetomir Stoyanov
2019-08-14 8:47 ` [PATCH v5 0/3] Add new trace-cmd record options: "--proc-map" Tzvetomir Stoyanov (VMware)
2019-08-27 23:28 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v5 1/3] trace-cmd: Extend ptrace logic to work with multiple filtered pids Tzvetomir Stoyanov (VMware)
2019-08-27 23:31 ` Steven Rostedt
2019-08-14 8:47 ` [PATCH v5 2/3] trace-cmd: Save the tracee address map into the trace.dat file Tzvetomir Stoyanov (VMware)
2019-08-14 8:47 ` [PATCH v5 3/3] trace-cmd: Add option to execute traced process as given user Tzvetomir Stoyanov (VMware)
2019-08-28 20:25 ` [PATCH v2 0/8] Separate trace-cmd and libtracecmd code Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814084712.28188-1-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).