* [PATCH] trace-cmd: Fix typo in use of file descriptor in conditional
@ 2019-09-04 11:55 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2019-09-04 11:55 UTC (permalink / raw)
To: linux-trace-devel@vger.kernel.org; +Cc: Uhanov, Kirill
From: "Uhanov, Kirill" <kirill.uhanov@intel.com>
tracecmd_create_buffer_recorder_maxkb() opens a file and uses fd2 as
the variable name to store the descriptor but the proceeding check on
the status of the opened file uses the variable name fd instead.
Signed-off-by: Kirill Uhanov <kirill.uhanov@intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
diff --git a/lib/trace-cmd/trace-recorder.c b/lib/trace-cmd/trace-recorder.c
index 0bd0657..650b259 100644
--- a/lib/trace-cmd/trace-recorder.c
+++ b/lib/trace-cmd/trace-recorder.c
@@ -244,7 +244,7 @@ tracecmd_create_buffer_recorder_maxkb(const char *file, int cpu, unsigned flags,
goto out;
fd2 = open(file2, O_RDWR | O_CREAT | O_TRUNC | O_LARGEFILE, 0644);
- if (fd < 0)
+ if (fd2 < 0)
goto err;
recorder = tracecmd_create_buffer_recorder_fd2(fd, fd2, cpu, flags, buffer, maxkb);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-09-04 11:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-04 11:55 [PATCH] trace-cmd: Fix typo in use of file descriptor in conditional Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).