From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, mike.auty@gmail.com
Subject: Re: [PATCH v2 1/5] kernel-shark: Show warning message when running as Root
Date: Thu, 19 Sep 2019 16:32:10 -0400 [thread overview]
Message-ID: <20190919163210.7740f372@gandalf.local.home> (raw)
In-Reply-To: <20190827182253.2d230e63@gandalf.local.home>
On Tue, 27 Aug 2019 18:22:53 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 26 Aug 2019 18:58:07 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
> > + warn.setText("KernelShark will have Root privileges.");
> > + warn.setInformativeText("Continue on your own risk.");
>
> This wasn't updated.
>
> From: https://lore.kernel.org/linux-trace-devel/20190809091914.75f553b2@gandalf.local.home/
>
> > > + QMessageBox warn;
> > > + warn.setText("KernelShark will have Root privileges.");
> > > + warn.setInformativeText("Continue on your one risk.");
> >
> > Probably better to say:
> >
> > "KernelShark is running with Root privileges."
> > "Continue at your own risk."
>
> I could update the patch if you like, instead of sending out another
> series. Let me finish the rest of the series.
>
We decided in our meeting that you were going to send a v3, right? Just
want to make sure (too many things to keep track of ;-)
Thanks!
-- Steve
next prev parent reply other threads:[~2019-09-19 20:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:58 [PATCH v2 0/5] Handle the case when KernelShark is started as Root Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 1/5] kernel-shark: Show warning message when running " Yordan Karadzhov (VMware)
2019-08-27 22:22 ` Steven Rostedt
2019-09-19 20:32 ` Steven Rostedt [this message]
2019-09-20 10:27 ` Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 2/5] kernel-shark: Don't use pkexec " Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 3/5] kernel-shark: Use standart error message in KsMainWindow::_record() Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 4/5] kernel-shark: Optimize the error messages when "Record" fails to start Yordan Karadzhov (VMware)
2019-08-26 15:58 ` [PATCH v2 5/5] kernel-shark: Better formatting of the error messages from "Record" Yordan Karadzhov (VMware)
2019-08-27 23:03 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919163210.7740f372@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mike.auty@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).