Re: [PATCH 0/4] Fix KernelShark appearance on dark color schemes

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 11 Oct 2019 00:24:25 +0300
Mikhail Rudenko <mike.rudenko@gmail.com> wrote:

> Currently a few widgets in Kernel Shark UI use custom stylesheets,
> unconditionally setting their background or text color (but not both!)
> to hard-coded values. This has a side effect of widget text being
> poorly readable on some color schemes (e.g. Breeze Dark, and dark
> schemes in general). This patch series tries to address this issue.
> 
> The first three patches are trivial: they ensure that whenever the
> background color of a widget is set to white via stylesheet, its text
> color is set to black.
> 
> The fourth one changes "inactive" marker selection button style to
> system default, making it look clickable on all color schemes.
> 
> Mikhail Rudenko (4):
>   kernel-shark: Set text color to black in KsDualMarker's QLabels
>   kernel-shark: Set text color to black in pointer position QLabel
>   kernel-shark: Set text color to black in KsTraceGraph's axes labels
>   kernel-shark: Change KsDualMarker's inactive button style to default
> 
>  kernel-shark/src/KsDualMarker.cpp | 11 ++---------
>  kernel-shark/src/KsTraceGraph.cpp |  6 ++++--
>  2 files changed, 6 insertions(+), 11 deletions(-)


Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Yordan,

If you are fine with these patches, could you pull them in and push
them to the repo?

-- Steve