From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA67AC282DD for ; Tue, 7 Jan 2020 20:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD51D20848 for ; Tue, 7 Jan 2020 20:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728584AbgAGUPA (ORCPT ); Tue, 7 Jan 2020 15:15:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:60408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728358AbgAGUPA (ORCPT ); Tue, 7 Jan 2020 15:15:00 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51DBA2080A; Tue, 7 Jan 2020 20:14:59 +0000 (UTC) Date: Tue, 7 Jan 2020 15:14:57 -0500 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: Sudip Mukherjee , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org Subject: Re: [PATCH] libtraceevent: Add dependency on libdl Message-ID: <20200107151457.39c1e81f@gandalf.local.home> In-Reply-To: <20200106221955.GC16851@kernel.org> References: <20191226224931.3458-1-sudipm.mukherjee@gmail.com> <20200106221955.GC16851@kernel.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 6 Jan 2020 19:19:55 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 26, 2019 at 10:49:31PM +0000, Sudip Mukherjee escreveu: > > event-plugin.c is calling dl_*() functions but it is not linked with > > libdl. As a result when we use ldd on the generated libtraceevent.so > > file, it does not list libdl as one of its dependencies. > > Add -ldl explicitly as done in tools/lib/lockdep. > > Rostedt, can you ack this one? It applies just fine. Reviewed-by: Steven Rostedt (VMware) Thanks! -- Steve > > - Arnaldo > > > Signed-off-by: Sudip Mukherjee > > --- > > tools/lib/traceevent/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile > > index c874c017c636..0d0575981cc7 100644 > > --- a/tools/lib/traceevent/Makefile > > +++ b/tools/lib/traceevent/Makefile > > @@ -143,7 +143,7 @@ $(TE_IN): force > > $(Q)$(MAKE) $(build)=libtraceevent > > > > $(OUTPUT)libtraceevent.so.$(EVENT_PARSE_VERSION): $(TE_IN) > > - $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@ > > + $(QUIET_LINK)$(CC) --shared $(LDFLAGS) $^ -ldl -Wl,-soname,libtraceevent.so.$(EP_VERSION) -o $@ > > @ln -sf $(@F) $(OUTPUT)libtraceevent.so > > @ln -sf $(@F) $(OUTPUT)libtraceevent.so.$(EP_VERSION) > > > > -- > > 2.11.0 >