* [PATCH] trace-cmd: Do not enable timestamps synchronization by default
@ 2020-04-24 9:27 Tzvetomir Stoyanov (VMware)
0 siblings, 0 replies; only message in thread
From: Tzvetomir Stoyanov (VMware) @ 2020-04-24 9:27 UTC (permalink / raw)
To: rostedt; +Cc: linux-trace-devel
When a timestamps synchronization data is detected in the trace file options,
and if this data is valid - timestamps correction is enabled by default. This
behavior was for PoC stage of the patches and should not be used in the final
version.
Timestamps synchronization should be enabled only if the file is opened
together with a file from the same tracing session. A new APIs were introduced
and already merged upstream for pairing peers from the same session. There is a
KernelShark patch which uses those new APIs to pair peers from the same session,
when loading the tracing files.
The default behavior, indented to be used for the PoC should be removed.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
lib/trace-cmd/trace-input.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 55c3d80a..25422755 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -2191,8 +2191,6 @@ static void tsync_offset_load(struct tracecmd_input *handle, char *buf)
host->ts_samples[j++] = host->ts_samples[i];
}
host->ts_samples_count = j;
- if (j)
- host->sync_enable = true;
}
static void tsync_check_enable(struct tracecmd_input *handle)
--
2.25.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-24 9:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-24 9:27 [PATCH] trace-cmd: Do not enable timestamps synchronization by default Tzvetomir Stoyanov (VMware)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).