From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C36C28CBC for ; Fri, 1 May 2020 02:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4F34208CA for ; Fri, 1 May 2020 02:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728092AbgEAC4j (ORCPT ); Thu, 30 Apr 2020 22:56:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:60886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728024AbgEAC4j (ORCPT ); Thu, 30 Apr 2020 22:56:39 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7B1E20836; Fri, 1 May 2020 02:56:38 +0000 (UTC) Date: Thu, 30 Apr 2020 22:56:37 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH 2/3] kernel-shark: Change the mechanism of the multi-threaded search Message-ID: <20200430225637.1b05d3ed@gandalf.local.home> In-Reply-To: <20200427151802.7a3a9be3@gandalf.local.home> References: <20200330161723.29816-1-y.karadz@gmail.com> <20200330161723.29816-3-y.karadz@gmail.com> <20200424161246.4d9f22b8@gandalf.local.home> <69e2a749-8582-35dc-0a6d-5d08988d4a5c@gmail.com> <20200427151802.7a3a9be3@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Mon, 27 Apr 2020 15:18:02 -0400 Steven Rostedt wrote: > > I would say we can apply both. What do you think? > > I'll try it out and let you know. Want to resend this patch with this change? -- Steve diff --git a/kernel-shark/src/KsModels.cpp b/kernel-shark/src/KsModels.cpp index ac58ca0a..51a7b79f 100644 --- a/kernel-shark/src/KsModels.cpp +++ b/kernel-shark/src/KsModels.cpp @@ -91,7 +91,7 @@ size_t KsFilterProxyModel::_search(int column, } /* Deal with the Progress bar of the seatch. */ - if ((index - first) > milestone) { + if ((index - first) >= milestone) { milestone += pbCount; if (notify) { /* diff --git a/kernel-shark/src/KsTraceViewer.cpp b/kernel-shark/src/KsTraceViewer.cpp index 12371ad7..0e0e3d4e 100644 --- a/kernel-shark/src/KsTraceViewer.cpp +++ b/kernel-shark/src/KsTraceViewer.cpp @@ -788,7 +788,7 @@ void KsTraceViewer::_searchItemsMT() false)); // notify = false while (_searchFSM.getState() == search_state_t::InProgress_s && - _proxyModel.searchProgress() < KS_PROGRESS_BAR_MAX - nThreads) { + _proxyModel.searchProgress() < KS_PROGRESS_BAR_MAX - nThreads - 1) { std::unique_lock lk(_proxyModel._mutex); _proxyModel._pbCond.wait(lk); _searchFSM.setProgress(_proxyModel.searchProgress());