From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10ABC54E49 for ; Sat, 9 May 2020 21:12:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9192820A8B for ; Sat, 9 May 2020 21:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728187AbgEIVMk convert rfc822-to-8bit (ORCPT ); Sat, 9 May 2020 17:12:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:58114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728098AbgEIVMk (ORCPT ); Sat, 9 May 2020 17:12:40 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B1E320A8B; Sat, 9 May 2020 21:12:39 +0000 (UTC) Date: Sat, 9 May 2020 17:12:37 -0400 From: Steven Rostedt To: Sudip Mukherjee Cc: "Yordan Karadzhov (VMware)" , Linux Trace Devel Subject: Re: [PATCH] trace-cmd: Fix build with gcc-10 Message-ID: <20200509171237.65f3b851@oasis.local.home> In-Reply-To: References: <20200417203914.26358-1-sudipm.mukherjee@gmail.com> <20200420154325.6072d96b@gandalf.local.home> <20200420155320.55d3c3f2@gandalf.local.home> <20200508101134.1f957f0b@gandalf.local.home> <20200509144853.081f4a70@oasis.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Sat, 9 May 2020 20:11:09 +0100 Sudip Mukherjee wrote: > On Sat, May 9, 2020 at 7:48 PM Steven Rostedt wrote: > > > > On Sat, 9 May 2020 19:30:38 +0100 > > Sudip Mukherjee wrote: > > > > > > > Thanks for the reminder, I haven't forgotten about it, just had other > > > > things added on top of my "todo" list. > > > > > > > > I'll go apply this now. > > > > > > Thanks. And now kernelshark fails. :( > > > > > > > Have you tried doing a make clean and building again? Sometimes the > > updates leave objects in place that need to be recompiled, but the > > dependencies may miss them. > > The build will be done in a new chroot every time so there is no > chance of objects from a previous build. Just to make sure I did 'git > clone' in a new folder and tried to build again. And it’s the same > failure. Also did 'make clean' and built again with the same failure. > > Hmm, I wonder if something like this fixes it? -- Steve diff --git a/kernel-shark/src/KsUtils.hpp b/kernel-shark/src/KsUtils.hpp index f44139bb..272a27d1 100644 --- a/kernel-shark/src/KsUtils.hpp +++ b/kernel-shark/src/KsUtils.hpp @@ -32,7 +32,7 @@ //! @cond Doxygen_Suppress -auto fontHeight = []() +static auto fontHeight = []() { QFont font; QFontMetrics fm(font); @@ -40,7 +40,7 @@ auto fontHeight = []() return fm.height(); }; -auto stringWidth = [](QString s) +static auto stringWidth = [](QString s) { QFont font; QFontMetrics fm(font);