From: Steven Rostedt <rostedt@goodmis.org>
To: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] trace-cmd: Add description of "-G" option
Date: Mon, 8 Jun 2020 17:42:37 -0400 [thread overview]
Message-ID: <20200608174237.7356c737@oasis.local.home> (raw)
In-Reply-To: <20200604115140.560f4eeb@gandalf.local.home>
On Thu, 4 Jun 2020 11:51:40 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > @@ -53,6 +53,7 @@ static struct usage_help usage_help[] = {
> > " --module filter module name\n"
> > " --by-comm used with --profile, merge events for related comms\n"
> > " --profile enable tracing options needed for report --profile\n"
> > + " -G when profiling, set soft and hard irqs as global\n"
>
> This should be in with the other "simple" options (those with a single
> character). The long options "--foo" should always be at the end after all
> simple ones.
Let me add. I see why you did it this way (because it is right under
the --profile), but I think it still should be with the other simple
options.
I'll update it.
Thanks!
-- Steve
prev parent reply other threads:[~2020-06-08 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 12:15 [PATCH v3 0/5] New trace-cmd "set" command and changes in "start" Tzvetomir Stoyanov (VMware)
2020-06-03 12:15 ` [PATCH v3 1/5] trace-cmd: Enable "trace-cmd start" to run a command Tzvetomir Stoyanov (VMware)
2020-06-08 19:35 ` Steven Rostedt
2020-06-08 20:39 ` [PATCH] trace-cmd: Have trace-cmd start wait for command unless --fork is specified Steven Rostedt
2020-06-03 12:15 ` [PATCH v3 2/5] trace-cmd: Add new subcommand "set" Tzvetomir Stoyanov (VMware)
2020-06-03 12:15 ` [PATCH v3 3/5] trace-cmd: Man page for "set" subcommand Tzvetomir Stoyanov (VMware)
2020-06-04 15:50 ` Steven Rostedt
2020-06-03 12:15 ` [PATCH v3 4/5] trace-cmd: Extend option "-v" to delete an ftrace instance Tzvetomir Stoyanov (VMware)
2020-06-03 12:15 ` [PATCH v3 5/5] trace-cmd: Add description of "-G" option Tzvetomir Stoyanov (VMware)
2020-06-04 15:51 ` Steven Rostedt
2020-06-08 21:42 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608174237.7356c737@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).