Re: [PATCH 0/8] Few libtraceeevnt fixes, suggested Namhyung Kim

[Steven Rostedt <rostedt@goodmis.org>]

On Tue, 14 Jul 2020 21:07:12 +0900
Namhyung Kim <namhyung@kernel.org> wrote:

> Hello,
> 
> On Tue, Jul 14, 2020 at 7:30 PM Tzvetomir Stoyanov (VMware)
> <tz.stoyanov@gmail.com> wrote:
> >
> > Fixes in libtraceeevnt, suggested by Namhyung Kim <namhyung@kernel.org>
> >
> > Tzvetomir Stoyanov (VMware) (8):
> >   trace-cmd: Document tep_load_plugins_hook()
> >   trace-cmd: Handle strdup() error in parse_option_name()
> >   trace-cmd: Fix typo in tep_plugin_add_option() description
> >   trace-cmd: Improve error handling of tep_plugin_add_option() API
> >   trace-cmd: Fixed broken indentation in parse_ip4_print_args()
> >   trace-cmd: Fixed type in PRINT_FMT_STING
> >   trace-cmd: Fixed description of tep_add_plugin_path() API
> >   trace-cmd: Handle possible strdup() error in tep_add_plugin_path() API  
> 
> Shouldn't the prefix be libtraceevent ?  Other than that,

Yes they should, because they are not trace-cmd specific.

> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks Namhyung!

-- Steve

> 
> Thanks
> Namhyung
> 
> >
> >  lib/traceevent/event-parse-local.h |  2 +-
> >  lib/traceevent/event-parse.c       | 10 +++---
> >  lib/traceevent/event-plugin.c      | 50 ++++++++++++++++++++++--------
> >  3 files changed, 43 insertions(+), 19 deletions(-)
> >
> > --
> > 2.26.2
> >