From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC06C433F1 for ; Thu, 16 Jul 2020 09:19:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69F8720656 for ; Thu, 16 Jul 2020 09:19:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OhAIbvMA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgGPJTi (ORCPT ); Thu, 16 Jul 2020 05:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbgGPJTh (ORCPT ); Thu, 16 Jul 2020 05:19:37 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B84C061755 for ; Thu, 16 Jul 2020 02:19:37 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id a1so4220019edt.10 for ; Thu, 16 Jul 2020 02:19:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hcz6JMCY2WohNVrTck3zudmbEe34LQkHVJbEtMwC8vw=; b=OhAIbvMA9ZBZSAvZj8OkWSXjIOAg3fYMj+lfzudaD8PB2rG+HIaTJ0vF3DYWaOBGzc U1P0Fkgn8qsn0NgO53vl1SfRVBmwDUfmjJQzdqrGcacUGp/dQmteaL9Odq98gRUqw6/C iY052z5YDDbqdMKA7CTb+EQOChmDu8tkMq/RqnatXh8oHxQ+0GG3qKh6QojIPk9j8rY3 9EGLn3BcjnGyKW8/VwmPerLP5hj74SPTLYWFS4VbfJs3S8bHYnqiVpJBV0JTa2lb662n AVGfejH8V/DVQ/nMeq/W0DnWN6qGVxjhAnzj5w/gR6VeoTrgPSGTpiV5d7PejFGBhJlK Q+FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hcz6JMCY2WohNVrTck3zudmbEe34LQkHVJbEtMwC8vw=; b=TVRH3R5G/fdwktZVmIVlJvMs+QbtO7GIGD0IZCuKv3ivO4S/OLDhT8cqond6ipnGP6 YvBkYuoqUP6BzSHM+PO8SUj3WjZac4mPakLmVCgttnOeHYZ7i/A170+39TjMYWi8ccxL fmSQ4LxPeOrR/+TYilLxcLKpSKckrlfkFTjo3d/lOZCktnfRkQFgW/xQi9vEOe7tDqd4 FnbQp2nPTDdiNmDws01EHnN2fYA6IcjY91+ydBuQNHfctytT3PY58iFW2xA9sP2t6/lb Oshr/h3IFG4BZZpGgLnTDqrqaq51Npdy0mp3YPV1a+wEcBdHDuDqHJneM6HNmYwaHSlI 2zKg== X-Gm-Message-State: AOAM5328+V3eO3iGOEdrU2clf0VpPv+lT93qxF2xOf5LKyhFu7KSp4qv n90NF4vE5B7bVhp+QJ+yO5qKiaHjZpc= X-Google-Smtp-Source: ABdhPJzAquvPOoHwIoNaMmERdbMK8rqJvSnI1hg7ecvlojeJBIacubs2LuG+OpNaP7VUUYudnDzkyw== X-Received: by 2002:aa7:d4d2:: with SMTP id t18mr3501623edr.166.1594891176101; Thu, 16 Jul 2020 02:19:36 -0700 (PDT) Received: from oberon.zico.biz ([83.222.187.186]) by smtp.gmail.com with ESMTPSA id x9sm4431534ejw.28.2020.07.16.02.19.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 02:19:35 -0700 (PDT) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH 8/8] tools lib traceevent: Handle possible strdup() error in tep_add_plugin_path() API Date: Thu, 16 Jul 2020 12:19:23 +0300 Message-Id: <20200716091923.2613228-9-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200716091923.2613228-1-tz.stoyanov@gmail.com> References: <20200716091923.2613228-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Free allocated resources and return -1 in case strdup() fails in tep_add_plugin_path() API. Link: https://lore.kernel.org/r/CAM9d7chfvJwodpVrHGc5E2J80peRojmYV_fD8x3cpn9HFRUw2g@mail.gmail.com Link: https://lore.kernel.org/linux-trace-devel/20200714103027.2477584-9-tz.stoyanov@gmail.com Suggested-by: Namhyung Kim Acked-by: Namhyung Kim Signed-off-by: Tzvetomir Stoyanov (VMware) Signed-off-by: Steven Rostedt (VMware) --- tools/lib/traceevent/event-plugin.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/lib/traceevent/event-plugin.c b/tools/lib/traceevent/event-plugin.c index f0877a7e3e8d..e7c2acb8680f 100644 --- a/tools/lib/traceevent/event-plugin.c +++ b/tools/lib/traceevent/event-plugin.c @@ -665,6 +665,10 @@ int tep_add_plugin_path(struct tep_handle *tep, char *path, return -1; dir->path = strdup(path); + if (!dir->path) { + free(dir); + return -1; + } dir->prio = prio; dir->next = tep->plugins_dir; tep->plugins_dir = dir; -- 2.26.2