From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org, douglas.raillard@arm.com
Subject: [PATCH] trace-cmd: Parse command lines with spaces
Date: Tue, 17 Nov 2020 13:22:10 +0200 [thread overview]
Message-ID: <20201117112210.207985-1-tz.stoyanov@gmail.com> (raw)
If a command line, saved in the trace.dat file, has spaces - it is not
parsed correctly by trace-cmd. Parsing is improved, so command lines
with spaces are displayed correctly.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=210193
Reported-by: Douglas RAILLARD <douglas.raillard@arm.com>
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
lib/trace-cmd/trace-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c
index 0ead96ea..bd09882b 100644
--- a/lib/trace-cmd/trace-util.c
+++ b/lib/trace-cmd/trace-util.c
@@ -63,7 +63,7 @@ void tracecmd_parse_cmdlines(struct tep_handle *pevent,
line = strtok_r(file, "\n", &next);
while (line) {
- sscanf(line, "%d %ms", &pid, &comm);
+ sscanf(line, "%d %m[^\n]s", &pid, &comm);
tep_register_comm(pevent, comm, pid);
free(comm);
line = strtok_r(NULL, "\n", &next);
--
2.28.0
reply other threads:[~2020-11-17 11:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117112210.207985-1-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=douglas.raillard@arm.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).