From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1CA2C5519F for ; Wed, 18 Nov 2020 22:13:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A699322248 for ; Wed, 18 Nov 2020 22:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726243AbgKRWNS (ORCPT ); Wed, 18 Nov 2020 17:13:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:43202 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgKRWNS (ORCPT ); Wed, 18 Nov 2020 17:13:18 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2165922242; Wed, 18 Nov 2020 22:13:17 +0000 (UTC) Date: Wed, 18 Nov 2020 17:13:14 -0500 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v4 06/20] kernel-shark: Add basic methods for Data streams Message-ID: <20201118171314.16662a9f@oasis.local.home> In-Reply-To: <20201118145003.156542-7-y.karadz@gmail.com> References: <20201118145003.156542-1-y.karadz@gmail.com> <20201118145003.156542-7-y.karadz@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 18 Nov 2020 16:49:49 +0200 "Yordan Karadzhov (VMware)" wrote: > +static void *index_to_ptr(unsigned int index) > +{ > + unsigned long p; > + > + p = INVALID_STREAM_MASK | index; > + > + return (void *) p; I'm curious to why you add a space between the *) and the p? This is now your project, so I wont complain about formats like this. You can decide it. But typecasts in Linux are expected to be together with what they typecast. Again, no change required, we just need to be consistent with it. (makes it easier to grep for) -- Steve > +} > +