From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2] libtracevent: Remove tempfile libtraceevent.pc
Date: Tue, 24 Nov 2020 08:51:05 -0500 [thread overview]
Message-ID: <20201124085105.1e87c220@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN4MosDu7weSfpR+4FW72dRGxCVsFHGa6dV_hv1ROBGffA@mail.gmail.com>
On Tue, 24 Nov 2020 07:26:25 +0200
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> On Mon, Nov 23, 2020 at 8:50 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > "make install" copies libtraceevent.pc.template to libtraceevent.pc and then
> > modifies it for the installation. This command is usually executed as root,
> > and when finished, it leaves behind the libtraceevent.pc file owned by root.
> >
> > Have the "make install" clean up and remove the temporary libtraceevent.pc
> > file, so that root owned files do not get left behind.
>
> Isn't it useful to have this file after the "make install" command, for debug
> purposes - to see how exactly it was modified ? The file is removed by
> "make clean".
Then it needs to be created via normal make. "make install" should leave no
"artifacts" lying around. It's usually done as root, and anything left may
be stuck there for the normal user (not be able to delete it).
The files removed by "make clean" are only those created by normal makes.
I can change the patch to have the creation of the package config created
by "make" and not by "make install", and then have it removed by "make
clean".
-- Steve
prev parent reply other threads:[~2020-11-24 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 18:48 [PATCH 0/2] libtraceevent: Some Makefile updates Steven Rostedt
2020-11-23 18:48 ` [PATCH 1/2] libtraceevent: Add libtraceevent.so.$(EP_VERSION) to targets and fix links Steven Rostedt
2020-11-24 5:10 ` Tzvetomir Stoyanov
2020-11-23 18:48 ` [PATCH 2/2] libtracevent: Remove tempfile libtraceevent.pc Steven Rostedt
2020-11-24 5:26 ` Tzvetomir Stoyanov
2020-11-24 13:51 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124085105.1e87c220@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).