From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: [PATCH 03/10] kernel-shark: Redefine the args of KsPlot::getColor()
Date: Wed, 9 Dec 2020 15:45:23 +0200 [thread overview]
Message-ID: <20201209134530.428368-4-y.karadz@gmail.com> (raw)
In-Reply-To: <20201209134530.428368-1-y.karadz@gmail.com>
The function was originally designed to return the color that
correspond to a given PID. However we now have 3 different color
maps (for PID, CPU Id and Stream Id) and the same method can be
used with each of the 3 maps. We also want to prevent the method
from modifying the map itself.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
src/KsPlotTools.cpp | 10 +++++-----
src/KsPlotTools.hpp | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/KsPlotTools.cpp b/src/KsPlotTools.cpp
index 7a0450b..52c3cbb 100644
--- a/src/KsPlotTools.cpp
+++ b/src/KsPlotTools.cpp
@@ -216,17 +216,17 @@ ColorTable getStreamColorTable()
}
/**
- * @brief Search the Hash table of Rainbow colors for a particular key (pid).
+ * @brief Search the Hash table of Rainbow colors for a particular key (Id).
*
* @param colors: Input location for the ColorTable instance.
- * @param pid: the Process Id to search for.
+ * @param id: The Id to search for.
*
- * @returns The Rainbow color of the key "pid". If "pid" does not exist, the
+ * @returns The Rainbow color of the key "id". If "id" does not exist, the
* returned color is Black.
*/
-Color getColor(ColorTable *colors, int pid)
+Color getColor(const ColorTable *colors, int id)
{
- auto item = colors->find(pid);
+ auto item = colors->find(id);
if (item != colors->end())
return item->second;
diff --git a/src/KsPlotTools.hpp b/src/KsPlotTools.hpp
index ab28f43..dbb15bf 100644
--- a/src/KsPlotTools.hpp
+++ b/src/KsPlotTools.hpp
@@ -80,7 +80,7 @@ ColorTable getCPUColorTable();
ColorTable getStreamColorTable();
-Color getColor(ColorTable *colors, int pid);
+Color getColor(const ColorTable *colors, int id);
/** Represents an abstract graphical element. */
class PlotObject {
--
2.25.1
next prev parent reply other threads:[~2020-12-09 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 13:45 [PATCH 00/10] kernel-shark: Update the C++ tools for plotting Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 01/10] kernel-shark: Integrate streams with KsPlotTools Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 02/10] kernel-shark: Add getStreamColorTable() Yordan Karadzhov (VMware)
2020-12-09 13:45 ` Yordan Karadzhov (VMware) [this message]
2020-12-09 13:45 ` [PATCH 04/10] kernel-shark: Add TextBox class to KsPlot namespace Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 05/10] kernel-shark: Consistent method naming in KsPlotTools Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 06/10] kernel-shark: Make the label part of the graph Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 07/10] kernel-shark: Remove the hard-coded Idle PID Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 08/10] kernel-shark: Add class Polyline to KsPlot namespace Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 09/10] kernel-shark: Add VirtBridge and VirtGap classes Yordan Karadzhov (VMware)
2020-12-09 13:45 ` [PATCH 10/10] kernel-shark: Add double click interface to PlotObject Yordan Karadzhov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209134530.428368-4-y.karadz@gmail.com \
--to=y.karadz@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).