From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] kernel-shark: Visualization plugin tools
Date: Thu, 7 Jan 2021 17:26:27 -0500 [thread overview]
Message-ID: <20210107172627.25233ee1@gandalf.local.home> (raw)
In-Reply-To: <20210107161547.207270-1-y.karadz@gmail.com>
On Thu, 7 Jan 2021 18:15:41 +0200
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> We implement a general purpose instruments, that can be used to
> implement efficient (fast) visualization plugins. We also use
> the new instrumentation to optimize the sched_events plugin.
>
> Changes in v2:
> * KS_DOUBLE_SIZE macro was simplified, based on the suggestion made by
> Steven in his review. A dedicated test case for the macro has been added.
> * Bug fix in kshark_free_data_container().
> * Bug fix in kshark_data_container_append().
The only change you need to make is to fix a couple of typos (there's a
couple more "Intput") and add your signed-off-by.
I originally just fixed the typos myself and added a comment about it in
the change log, but when I saw the missing SOB, that's something I can't
fix.
Please send a v3.
Thanks!
-- Steve
>
>
> Yordan Karadzhov (VMware) (6):
> kernel-shark: Add KS_DOUBLE_SIZE macro
> kernel-shark: Add kshark_data_container to libkshark
> kernel-shark: Add KS_DEFINE_PLUGIN_CONTEXT macro
> kernel-shark: Start using C++17
> kernel-shark: Add plotting methods to KsPlugins
> kernel-shark: Speed-up the sched_events plugin
>
> CMakeLists.txt | 8 +-
> src/CMakeLists.txt | 5 +-
> src/KsPlugins.cpp | 416 ++++++++++++++++++++++++++++++++++++
> src/KsPlugins.hpp | 48 +++++
> src/libkshark-plugin.h | 59 +++++
> src/libkshark-tepdata.c | 34 +++
> src/libkshark-tepdata.h | 7 +
> src/libkshark.c | 158 +++++++++++++-
> src/libkshark.h | 43 ++++
> src/plugins/CMakeLists.txt | 11 +-
> src/plugins/SchedEvents.cpp | 310 +++++++--------------------
> src/plugins/sched_events.c | 393 +++++++++++-----------------------
> src/plugins/sched_events.h | 50 ++---
> tests/libkshark-tests.cpp | 89 ++++++++
> 14 files changed, 1071 insertions(+), 560 deletions(-)
> create mode 100644 src/KsPlugins.cpp
>
prev parent reply other threads:[~2021-01-07 22:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 16:15 [PATCH v2 0/6] kernel-shark: Visualization plugin tools Yordan Karadzhov (VMware)
2021-01-07 16:15 ` [PATCH v2 1/6] kernel-shark: Add KS_DOUBLE_SIZE macro Yordan Karadzhov (VMware)
2021-01-07 16:15 ` [PATCH v2 2/6] kernel-shark: Add kshark_data_container to libkshark Yordan Karadzhov (VMware)
2021-01-07 22:24 ` Steven Rostedt
2021-01-07 16:15 ` [PATCH v2 3/6] kernel-shark: Add KS_DEFINE_PLUGIN_CONTEXT macro Yordan Karadzhov (VMware)
2021-01-07 22:23 ` Steven Rostedt
2021-01-07 16:15 ` [PATCH v2 4/6] kernel-shark: Start using C++17 Yordan Karadzhov (VMware)
2021-01-07 16:15 ` [PATCH v2 5/6] kernel-shark: Add plotting methods to KsPlugins Yordan Karadzhov (VMware)
2021-01-07 16:15 ` [PATCH v2 6/6] kernel-shark: Speed-up the sched_events plugin Yordan Karadzhov (VMware)
2021-01-07 22:26 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107172627.25233ee1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).