* [PATCH] trace-cmd: Fix plist allocation check in trace-msg.c
@ 2021-02-03 21:54 Steven Rostedt
0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2021-02-03 21:54 UTC (permalink / raw)
To: Linux Trace Devel
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The plist allocation check in get_trace_req_protos() returns error on a
successful allocation. Fix it.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
lib/trace-cmd/trace-msg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c
index 8d2ed38d..611af2c1 100644
--- a/lib/trace-cmd/trace-msg.c
+++ b/lib/trace-cmd/trace-msg.c
@@ -981,7 +981,7 @@ static int get_trace_req_protos(char *buf, int length,
}
plist = calloc(1, sizeof(struct tracecmd_tsync_protos));
- if (plist)
+ if (!plist)
goto error;
plist->names = calloc(count + 1, sizeof(char *));
if (!plist->names)
--
2.25.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-03 21:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-03 21:54 [PATCH] trace-cmd: Fix plist allocation check in trace-msg.c Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).