From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v28 2/8] trace-cmd: Fix bug in getting tracing dir in trace-cmd agent
Date: Mon, 8 Feb 2021 08:17:37 +0200 [thread overview]
Message-ID: <20210208061743.510964-3-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210208061743.510964-1-tz.stoyanov@gmail.com>
In trace-cmd agent context, when getting the tracing directory, a bug
using srtcpy() was instroduced by that commit:
https://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git/commit/?id=b8498696e0e8d7b7cce8f50f92e1fa94d9127e6e
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
tracecmd/trace-record.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index a0a0b8b5..efd96d27 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -3341,7 +3341,7 @@ static int create_recorder(struct buffer_instance *instance, int cpu,
const char *dir = tracefs_tracing_dir();
if (dir)
- path = strdup(path);
+ path = strdup(dir);
}
if (!path)
die("can't get the tracing directory");
--
2.29.2
next prev parent reply other threads:[~2021-02-08 6:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 6:17 [PATCH v28 0/8] Timestamp synchronization of host - guest tracing session Tzvetomir Stoyanov (VMware)
2021-02-08 6:17 ` [PATCH v28 1/8] trace-cmd: Save command lines in VM agent Tzvetomir Stoyanov (VMware)
2021-02-17 20:55 ` Steven Rostedt
2021-02-08 6:17 ` Tzvetomir Stoyanov (VMware) [this message]
2021-02-08 6:17 ` [PATCH v28 3/8] trace-cmd: Removed unused s64 define Tzvetomir Stoyanov (VMware)
2021-02-08 6:17 ` [PATCH v28 4/8] trace-cmd: Add timestamp synchronization per vCPU Tzvetomir Stoyanov (VMware)
2021-02-08 6:17 ` [PATCH v28 5/8] trace-cmd: Add dummy function to initialize timestamp sync logic Tzvetomir Stoyanov (VMware)
2021-02-08 6:17 ` [PATCH v28 6/8] trace-cmd: [POC] PTP-like algorithm for host - guest timestamp synchronization Tzvetomir Stoyanov (VMware)
2021-02-08 6:17 ` [PATCH v28 7/8] trace-cmd: Debug scripts for " Tzvetomir Stoyanov (VMware)
2021-02-08 6:17 ` [PATCH v28 8/8] trace-cmd [POC]: Add KVM timestamp synchronization plugin Tzvetomir Stoyanov (VMware)
2021-02-16 20:48 ` Steven Rostedt
2021-02-09 5:32 ` [PATCH v28 0/8] Timestamp synchronization of host - guest tracing session Dario Faggioli
2021-02-09 6:03 ` Tzvetomir Stoyanov
2021-02-09 6:08 ` Tzvetomir Stoyanov
2021-02-09 7:28 ` Dario Faggioli
2021-02-09 11:44 ` Tzvetomir Stoyanov
2021-02-09 12:24 ` Dario Faggioli
2021-02-09 13:00 ` Tzvetomir Stoyanov
2021-02-09 15:28 ` Dario Faggioli
2021-02-09 17:01 ` Tzvetomir Stoyanov
2021-02-10 22:02 ` Steven Rostedt
2021-02-10 23:35 ` Dario Faggioli
2021-02-10 21:59 ` Steven Rostedt
2021-02-10 23:33 ` Dario Faggioli
2021-02-09 7:18 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208061743.510964-3-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).