From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A797C433E0 for ; Fri, 19 Feb 2021 14:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E73C64D9A for ; Fri, 19 Feb 2021 14:42:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhBSOmw (ORCPT ); Fri, 19 Feb 2021 09:42:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:34506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhBSOms (ORCPT ); Fri, 19 Feb 2021 09:42:48 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C87664DA8; Fri, 19 Feb 2021 14:42:08 +0000 (UTC) Date: Fri, 19 Feb 2021 09:42:06 -0500 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH] libtracefs: Add new API for open trace marker file Message-ID: <20210219094206.27d51db6@gandalf.local.home> In-Reply-To: <20210219092642.0f496a19@gandalf.local.home> References: <20210219055353.2244340-1-tz.stoyanov@gmail.com> <20210219092642.0f496a19@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, 19 Feb 2021 09:26:42 -0500 Steven Rostedt wrote: > Where tracefs_print_init() will open the trace_marker for that instance > (NULL being the top level), and storing it in the instance structure. BTW, in all cases, if NULL is used, we need to have a global variable to keep track of the trace_marker file descriptor. All should be marked as "close on exec", as we don't want this to be passed to new executables (if someone wants that, then they can use the API in this thread). -- Steve