linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-trace-devel@vger.kernel.org
Subject: [PATCH 1/9 v2] trace-cmd restore: Fix to add saved cmdlines after calling tracecmd_create_init_file_override()
Date: Fri, 05 Mar 2021 17:52:24 -0500	[thread overview]
Message-ID: <20210305225947.378797358@goodmis.org> (raw)
In-Reply-To: 20210305225223.794554327@goodmis.org

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

The saving of command lines was moved out of the create_file() logic to
capture them after the tracing has finished. But this broke trace-cmd
restore as it expected them to be saved by the
tracecmd_create_init_file_override() function.

Link: https://lore.kernel.org/linux-trace-devel/20210301143856.788923617@goodmis.org

Fixes: 1eea02a4b ("trace-cmd: Write saved cmdlines in the trace file at the end of the trace.")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 tracecmd/trace-restore.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tracecmd/trace-restore.c b/tracecmd/trace-restore.c
index 98e757337a03..13f803053582 100644
--- a/tracecmd/trace-restore.c
+++ b/tracecmd/trace-restore.c
@@ -94,6 +94,8 @@ void trace_restore (int argc, char **argv)
 							    kallsyms);
 		if (!handle)
 			die("Unabled to create output file %s", output);
+		if (tracecmd_write_cmdlines(handle) < 0)
+			die("Failed to write command lines");
 		tracecmd_output_close(handle);
 		exit(0);
 	}
-- 
2.30.0



  reply	other threads:[~2021-03-05 23:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 22:52 [PATCH 0/9 v2] trace-cmd: Fixes for trace-cmd restore Steven Rostedt
2021-03-05 22:52 ` Steven Rostedt [this message]
2021-03-05 22:52 ` [PATCH 2/9 v2] trace-cmd: Move tracecmd_write_cmdlines() out of tracecmd_append_cpu_data() Steven Rostedt
2021-03-05 22:52 ` [PATCH 3/9 v2] trace-cmd: Move the output state updates into the functions that change the state Steven Rostedt
2021-03-05 22:52 ` [PATCH 4/9 v2] trace-cmd: Move the input " Steven Rostedt
2021-03-05 22:52 ` [PATCH 5/9 v2] trace-cmd input: Validate the input handle when copying from it Steven Rostedt
2021-03-05 22:52 ` [PATCH 6/9 v2] trace-cmd: Have tracecmd_read_headers() specify the state to read up to Steven Rostedt
2021-03-05 22:52 ` [PATCH 7/9 v2] trace-cmd: Have tracecmd_get_file_state() return the enum Steven Rostedt
2021-03-05 22:52 ` [PATCH 8/9 v2] trace-cmd input: Add validation updates to the copy of a handle Steven Rostedt
2021-03-05 22:52 ` [PATCH 9/9 v2] trace-cmd: Have tracecmd_copy_headers() have a start and stop state Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305225947.378797358@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).