From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05405C433DB for ; Wed, 24 Mar 2021 20:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBC7861A17 for ; Wed, 24 Mar 2021 20:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238242AbhCXU4G (ORCPT ); Wed, 24 Mar 2021 16:56:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:56606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238219AbhCXUzH (ORCPT ); Wed, 24 Mar 2021 16:55:07 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19737619B4; Wed, 24 Mar 2021 20:55:07 +0000 (UTC) Date: Wed, 24 Mar 2021 16:55:05 -0400 From: Steven Rostedt To: Tzvetomir Stoyanov Cc: Linux Trace Devel Subject: Re: [PATCH v3 06/23] trace-cmd: Add new trace-cmd clock tsc2nsec Message-ID: <20210324165505.44f9ce0f@gandalf.local.home> In-Reply-To: References: <20210324130418.436206-1-tz.stoyanov@gmail.com> <20210324130418.436206-7-tz.stoyanov@gmail.com> <20210324112001.0d897bdb@gandalf.local.home> <20210324122250.50fb6f9b@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 24 Mar 2021 18:56:39 +0200 Tzvetomir Stoyanov wrote: > > > to free. That's why both are valid. I was wondering if to use strdup > > > or simple assignment, and decided to allocate a memory. One day we may > > > implement free_instance(), there are a lot of resources in an instance > > > that should be freed. > > > > Perhaps that "one day" should be this week ;-) > > That means to implement a cleanup after each trace-cmd subcommand ? > Currently, trace-cmd just exits and not freeing that memory is not a > big problem. I was thinking many times to implement free_instance(), > but there is no sense for it if there is no cleanup logic at the end > of each command. It's not top priority. But something we should keep in mind. -- Steve