* [PATCH v2] libtracefs: Prefer using "const char *" arguments
@ 2021-03-25 12:29 Yordan Karadzhov (VMware)
0 siblings, 0 replies; only message in thread
From: Yordan Karadzhov (VMware) @ 2021-03-25 12:29 UTC (permalink / raw)
To: rostedt; +Cc: linux-trace-devel, Yordan Karadzhov (VMware)
All functions should receive const string arguments, except in the
cases when the argument string itself needs to be modified.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@gmail.com>
---
include/tracefs.h | 4 ++--
src/tracefs-instance.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/tracefs.h b/include/tracefs.h
index f3eec62..05bd0ef 100644
--- a/include/tracefs.h
+++ b/include/tracefs.h
@@ -42,8 +42,8 @@ int tracefs_instance_file_open(struct tracefs_instance *instance,
int tracefs_instances_walk(int (*callback)(const char *, void *), void *context);
bool tracefs_instance_exists(const char *name);
-bool tracefs_file_exists(struct tracefs_instance *instance, char *name);
-bool tracefs_dir_exists(struct tracefs_instance *instance, char *name);
+bool tracefs_file_exists(struct tracefs_instance *instance, const char *name);
+bool tracefs_dir_exists(struct tracefs_instance *instance, const char *name);
int tracefs_trace_is_on(struct tracefs_instance *instance);
int tracefs_trace_on(struct tracefs_instance *instance);
diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c
index 0df4e13..0df313c 100644
--- a/src/tracefs-instance.c
+++ b/src/tracefs-instance.c
@@ -436,7 +436,7 @@ int tracefs_instance_file_open(struct tracefs_instance *instance,
}
static bool check_file_exists(struct tracefs_instance *instance,
- char *name, bool dir)
+ const char *name, bool dir)
{
char file[PATH_MAX];
struct stat st;
@@ -482,7 +482,7 @@ bool tracefs_instance_exists(const char *name)
*
* If a directory with the given name exists, false is returned.
*/
-bool tracefs_file_exists(struct tracefs_instance *instance, char *name)
+bool tracefs_file_exists(struct tracefs_instance *instance, const char *name)
{
return check_file_exists(instance, name, false);
}
@@ -494,7 +494,7 @@ bool tracefs_file_exists(struct tracefs_instance *instance, char *name)
*
* Returns true if the directory exists, false otherwise
*/
-bool tracefs_dir_exists(struct tracefs_instance *instance, char *name)
+bool tracefs_dir_exists(struct tracefs_instance *instance, const char *name)
{
return check_file_exists(instance, name, true);
}
--
2.27.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-25 12:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-25 12:29 [PATCH v2] libtracefs: Prefer using "const char *" arguments Yordan Karadzhov (VMware)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).