Re: [PATCH v2] libtracefs: Add new API for open trace marker file

[Steven Rostedt <rostedt@goodmis.org>]

On Thu,  8 Apr 2021 11:08:21 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:

> Added new APIs for opening trace_marker file of given instance:
>    tracefs_marker_init()
>    tracefs_marker_write()
>    tracefs_marker_vprint()
>    tracefs_marker_print()
>    tracefs_marker_close()

I really don't like the name as it's more about the tracefs implementation
and not what it's used for. I much rather have:

	tracefs_print_init();
	tracefs_printf();
	tracefs_vprintf();
	tracefs_print_close();

And you should never write binary into the trace_marker file, as it always
expects ascii strings. That's the trace_marker_raw file. In which case we
could have:

	tracefs_binary_init();
	tracefs_binary_write();
	tracefs_binary_close();

For binary writes.

-- Steve