From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org, tz.stoyanov@gmail.com
Subject: Re: [PATCH v4 4/5] libtracefs: Option's bit masks to be owned by the instance
Date: Fri, 9 Apr 2021 14:40:18 -0400 [thread overview]
Message-ID: <20210409144018.6dd426b3@gandalf.local.home> (raw)
In-Reply-To: <20210409180423.72497-5-y.karadz@gmail.com>
On Fri, 9 Apr 2021 21:04:22 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> +__hidden inline struct tracefs_options_mask *
> +supported_opts_mask(struct tracefs_instance *instance)
> +{
> + return instance? &instance->supported_opts : &toplevel_supported_opts;
> +}
> +
> +__hidden inline struct tracefs_options_mask *
> +enabled_opts_mask(struct tracefs_instance *instance)
> +{
> + return instance? &instance->enabled_opts : &toplevel_enabled_opts;
> +}
I'll fix this up, but for the future, there should be a space between the
condition and the "?".
return instance ? &instance->supported_opts : &toplevel_supported_opts;
-- Steve
next prev parent reply other threads:[~2021-04-09 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 18:04 [PATCH v4 0/5] Refactor the APIs for tracing options Yordan Karadzhov (VMware)
2021-04-09 18:04 ` [PATCH v4 1/5] libtracefs: Fix issues with tracefs_option_id() Yordan Karadzhov (VMware)
2021-04-09 18:04 ` [PATCH v4 2/5] libtracefs: Modify the arguments of tracefs_option_is_set() Yordan Karadzhov (VMware)
2021-04-09 18:04 ` [PATCH v4 3/5] libtracefs: Encapsulate "struct tracefs_options_mask" Yordan Karadzhov (VMware)
2021-04-09 18:04 ` [PATCH v4 4/5] libtracefs: Option's bit masks to be owned by the instance Yordan Karadzhov (VMware)
2021-04-09 18:40 ` Steven Rostedt [this message]
2021-04-09 18:04 ` [PATCH v4 5/5] libtracefs: Rename tracefs_option_is_set() Yordan Karadzhov (VMware)
2021-04-09 18:26 ` [PATCH v4 0/5] Refactor the APIs for tracing options Steven Rostedt
2021-04-09 18:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409144018.6dd426b3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).