From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B020C43460 for ; Fri, 9 Apr 2021 18:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64B4D61056 for ; Fri, 9 Apr 2021 18:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233332AbhDISke (ORCPT ); Fri, 9 Apr 2021 14:40:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:50512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234464AbhDISkd (ORCPT ); Fri, 9 Apr 2021 14:40:33 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 561CA610FC; Fri, 9 Apr 2021 18:40:20 +0000 (UTC) Date: Fri, 9 Apr 2021 14:40:18 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org, tz.stoyanov@gmail.com Subject: Re: [PATCH v4 4/5] libtracefs: Option's bit masks to be owned by the instance Message-ID: <20210409144018.6dd426b3@gandalf.local.home> In-Reply-To: <20210409180423.72497-5-y.karadz@gmail.com> References: <20210409180423.72497-1-y.karadz@gmail.com> <20210409180423.72497-5-y.karadz@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Fri, 9 Apr 2021 21:04:22 +0300 "Yordan Karadzhov (VMware)" wrote: > +__hidden inline struct tracefs_options_mask * > +supported_opts_mask(struct tracefs_instance *instance) > +{ > + return instance? &instance->supported_opts : &toplevel_supported_opts; > +} > + > +__hidden inline struct tracefs_options_mask * > +enabled_opts_mask(struct tracefs_instance *instance) > +{ > + return instance? &instance->enabled_opts : &toplevel_enabled_opts; > +} I'll fix this up, but for the future, there should be a space between the condition and the "?". return instance ? &instance->supported_opts : &toplevel_supported_opts; -- Steve