From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Have tracefs_instance_destroy() match the man page
Date: Mon, 12 Apr 2021 16:53:36 -0400 [thread overview]
Message-ID: <20210412165336.37d46e05@gandalf.local.home> (raw)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
According to the man page of tracefs_instance_destroy():
"The tracefs_instance_destroy() frees the instance structure, and will also
remove the trace instance from the system."
But, it does not actually free the instance. Have it do so.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
src/tracefs-instance.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c
index b8ce36f..67e7991 100644
--- a/src/tracefs-instance.c
+++ b/src/tracefs-instance.c
@@ -247,7 +247,7 @@ int tracefs_instance_destroy(struct tracefs_instance *instance)
if (path)
ret = rmdir(path);
tracefs_put_tracing_file(path);
-
+ tracefs_instance_free(instance);
return ret;
}
--
2.29.2
reply other threads:[~2021-04-12 20:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412165336.37d46e05@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).