From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF2D0C433B4 for ; Thu, 15 Apr 2021 13:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A19F61249 for ; Thu, 15 Apr 2021 13:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbhDON3b (ORCPT ); Thu, 15 Apr 2021 09:29:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:43746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230202AbhDON3a (ORCPT ); Thu, 15 Apr 2021 09:29:30 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4926611F1; Thu, 15 Apr 2021 13:29:06 +0000 (UTC) Date: Thu, 15 Apr 2021 09:29:05 -0400 From: Steven Rostedt To: Dario Faggioli Cc: Andrew Cooper , Giuseppe Eletto , linux-trace-devel@vger.kernel.org, xen-devel@lists.xenproject.org, Enrico Bini Subject: Re: A KernelShark plugin for Xen traces analysis Message-ID: <20210415092905.5c2d7aad@gandalf.local.home> In-Reply-To: <281ee74f5ce416feeafbca7cb8370889e0d2067f.camel@suse.com> References: <7184a7d7-6bca-4106-d70e-8cf9d5b227fb@citrix.com> <20210414150752.34366b99@gandalf.local.home> <281ee74f5ce416feeafbca7cb8370889e0d2067f.camel@suse.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 15 Apr 2021 02:50:53 +0200 Dario Faggioli wrote: > On Wed, 2021-04-14 at 15:07 -0400, Steven Rostedt wrote: > > On Wed, 14 Apr 2021 19:11:19 +0100 > > Andrew Cooper wrote: > > > > > Where the plugin (ought to) live depends heavily on whether we > > > consider > > > the trace format a stable ABI or not. > > > > Agreed. Like the VMware plugin to handle ESX traces. It's internal > > and not > > published as the API is not stable. > > > Mmm... Does this imply that Linux's tracepoints should be considered a > stable ABI then? :-D :-D :-D Some already are. Like the sched_switch tracepoint. That's one of the reasons Peter Zijlstra now hates exported tracepoints. > > > But if it ever becomes stable, and you would like it to live with > > KernelShark, we are looking to have a place to store third party > > plugins. > > > Sure. TBH, either Xen or KernelShark main or plugin repositories would > be fine for me. > > Which doesn't mean we should choose randomly, as clearly each solution > has pros and cons that needs to be evaluated. > > I'm just saying that we would prefer the plugin to end up in one of > those places, rather than remaining its own project. And of course > we're up for maintaining it, wherever it lands. :-) Like I said, we can have a third party repository within the KernelShark repo (or along side of it). As a claws-mail user, I like their method. They have a bunch of plugins you can add that they have in their repo, but those plugins are maintained by different people. -- Steve > > > We are working to make sure that the API for KernelShark plugins > > remains > > stable, so your plugins should always work too. > > > Great! > > Regards