From: Steven Rostedt <rostedt@goodmis.org>
To: Yordan Karadzhov <y.karadz@gmail.com>
Cc: Stefano De Venuto <stefano.devenuto99@gmail.com>,
linux-trace-devel@vger.kernel.org, dfaggioli@suse.com
Subject: Re: [RFC] Simple tool for VMEnters/VMExits matching and trace validation
Date: Tue, 20 Apr 2021 22:17:46 -0400 [thread overview]
Message-ID: <20210420221746.1899d496@oasis.local.home> (raw)
In-Reply-To: <7edad92d-3297-fd42-9ac2-0334816fb524@gmail.com>
On Tue, 20 Apr 2021 11:12:59 +0300
Yordan Karadzhov <y.karadz@gmail.com> wrote:
> > diff --git a/examples/checker.c b/examples/checker.c
> > new file mode 100644
> > index 0000000..0b04343
> > --- /dev/null
> > +++ b/examples/checker.c
> > @@ -0,0 +1,202 @@
>
> The first problem is that this patch fails to apply. My guess is that
> you hand-edited the patch and removed some lines starting with "+". Note
> that the total number of additions and removals in the file is indicated
> in the line above. If this number does not match the number of lines
> starting with "+", the patch will fail to apply.
>
> As a general advise - try to avoid hand-editing patches unless you are
> certain you know what you are doing.
Or hand edit the patches using emacs ;-)
That's because emacs has a "patch mode" that updates those numbers when
you modify the patch!
-- Steve
next prev parent reply other threads:[~2021-04-21 2:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 16:46 [RFC] Simple tool for VMEnters/VMExits matching and trace validation Stefano De Venuto
2021-04-16 17:47 ` Dario Faggioli
2021-04-16 20:48 ` Stefano De Venuto
2021-04-16 21:32 ` Steven Rostedt
2021-04-17 6:43 ` Dario Faggioli
2021-04-20 8:12 ` Yordan Karadzhov
2021-04-21 2:17 ` Steven Rostedt [this message]
2021-04-21 9:14 ` Yordan Karadzhov
2021-05-01 6:11 ` Stefano De Venuto
2021-05-01 6:11 ` Stefano De Venuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420221746.1899d496@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=dfaggioli@suse.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=stefano.devenuto99@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).