From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH 3/7] trace-cmd check-events: Add --verbose
Date: Wed, 28 Apr 2021 10:46:26 +0300 [thread overview]
Message-ID: <20210428074630.757694-4-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210428074630.757694-1-tz.stoyanov@gmail.com>
Add new "trace-cmd check-events --verbose" argument for setting the desired
log level.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
.../trace-cmd/trace-cmd-check-events.1.txt | 9 +++++++++
tracecmd/trace-check-events.c | 16 +++++++++++++++-
tracecmd/trace-usage.c | 1 +
3 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/Documentation/trace-cmd/trace-cmd-check-events.1.txt b/Documentation/trace-cmd/trace-cmd-check-events.1.txt
index c98ff3c6..40c3c8cd 100644
--- a/Documentation/trace-cmd/trace-cmd-check-events.1.txt
+++ b/Documentation/trace-cmd/trace-cmd-check-events.1.txt
@@ -24,6 +24,15 @@ OPTIONS
-------
*-N* - Don't load plugins
+*--verbose* 'level'::
+ Set the log level. Supported log levels are "none", "critical", "error", "warning",
+ "info", "debug", "all" or their identifiers "0", "1", "2", "3", "4", "5", "6". Setting the log
+ level to specific value enables all logs from that and all previous levels.
+
+ Example: enable all critical, error and warning logs
+
+ trace-cmd check-events --verbose warning
+
SEE ALSO
--------
trace-cmd(1), trace-cmd-record(1), trace-cmd-report(1), trace-cmd-stop(1),
diff --git a/tracecmd/trace-check-events.c b/tracecmd/trace-check-events.c
index bd19feca..cf34912a 100644
--- a/tracecmd/trace-check-events.c
+++ b/tracecmd/trace-check-events.c
@@ -10,6 +10,10 @@
#include "tracefs.h"
#include "trace-local.h"
+enum {
+ OPT_verbose = 255,
+};
+
void trace_check_events(int argc, char **argv)
{
const char *tracing;
@@ -18,8 +22,14 @@ void trace_check_events(int argc, char **argv)
struct tep_handle *pevent = NULL;
struct tep_plugin_list *list = NULL;
int open_flags = 0;
+ int option_index = 0;
+ static struct option long_options[] = {
+ {"verbose", required_argument, NULL, OPT_verbose},
+ {NULL, 0, NULL, 0}
+ };
+
- while ((c = getopt(argc-1, argv+1, "+hN")) >= 0) {
+ while ((c = getopt_long(argc-1, argv+1, "+hN", long_options, &option_index)) >= 0) {
switch (c) {
case 'h':
default:
@@ -28,6 +38,10 @@ void trace_check_events(int argc, char **argv)
case 'N':
open_flags |= TRACECMD_FL_LOAD_NO_PLUGINS;
break;
+ case OPT_verbose:
+ if (trace_set_verbose(optarg) < 0)
+ die("invalid verbose level %s", optarg);
+ break;
}
}
tracing = tracefs_tracing_dir();
diff --git a/tracecmd/trace-usage.c b/tracecmd/trace-usage.c
index 7019ab97..cacec3c5 100644
--- a/tracecmd/trace-usage.c
+++ b/tracecmd/trace-usage.c
@@ -363,6 +363,7 @@ static struct usage_help usage_help[] = {
"parse trace event formats",
" %s check-events [-N]\n"
" -N do not load any plugins\n"
+ " --verbose 'level' Set the desired log level\n"
},
{
"dump",
--
2.30.2
next prev parent reply other threads:[~2021-04-28 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 7:46 [PATCH 0/7] Add --verbose option to bunch of trace-cmd commands Tzvetomir Stoyanov (VMware)
2021-04-28 7:46 ` [PATCH 1/7] trace-cmd report: Add --verbose Tzvetomir Stoyanov (VMware)
2021-04-28 7:46 ` [PATCH 2/7] trace-cmd agent: " Tzvetomir Stoyanov (VMware)
2021-04-28 7:46 ` Tzvetomir Stoyanov (VMware) [this message]
2021-04-28 7:46 ` [PATCH 4/7] trace-cmd: Add --verbose to bunch of trace-cmd commands Tzvetomir Stoyanov (VMware)
2021-04-28 7:46 ` [PATCH 5/7] trace-cmd listen: Add --verbose Tzvetomir Stoyanov (VMware)
2021-04-28 7:46 ` [PATCH 6/7] trace-cmd stack: " Tzvetomir Stoyanov (VMware)
2021-04-28 7:46 ` [PATCH 7/7] trace-cmd dump: " Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210428074630.757694-4-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).