From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Free the regex in update_filter()
Date: Thu, 6 May 2021 10:00:10 -0400 [thread overview]
Message-ID: <20210506100010.483b2374@gandalf.local.home> (raw)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
A regex is used to match functions in update_filter() using the regcomp()
functionality. But regcomp() needs to release its resources via regfree()
which is lacking in this function.
Fixes: 2df4a7ea ("libtracefs: Add checking of available_filter_functions to tracefs_function_filter()")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
src/tracefs-tools.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/tracefs-tools.c b/src/tracefs-tools.c
index 6ef17f6..993fb3c 100644
--- a/src/tracefs-tools.c
+++ b/src/tracefs-tools.c
@@ -816,6 +816,7 @@ static int update_filter(const char *filter_path, int *fd,
}
out_free:
+ regfree(&func_filter.re);
free_func_list(func_list);
out:
pthread_mutex_unlock(lock);
--
2.29.2
reply other threads:[~2021-05-06 14:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506100010.483b2374@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).