From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v2 1/3] libtracefs: Add API to set the log level
Date: Fri, 7 May 2021 12:51:52 +0300 [thread overview]
Message-ID: <20210507095154.1080202-2-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210507095154.1080202-1-tz.stoyanov@gmail.com>
Library log level is added and new API to set the desired level.
Log levels defined in libtraceevent are used. By default, the log level
of tracefs library is TEP_LOG_CRITICAL. When a new level is set, it is
also propagated to the libtraceevent.
Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
include/tracefs.h | 4 ++++
src/tracefs-utils.c | 18 +++++++++++++++++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/include/tracefs.h b/include/tracefs.h
index 73ee42b..08dda13 100644
--- a/include/tracefs.h
+++ b/include/tracefs.h
@@ -180,4 +180,8 @@ int tracefs_function_filter(struct tracefs_instance *instance, const char *filte
int tracefs_function_notrace(struct tracefs_instance *instance, const char *filter,
const char *module, unsigned int flags);
+
+/* Control library logs */
+void tracefs_set_loglevel(enum tep_loglevel level);
+
#endif /* _TRACE_FS_H */
diff --git a/src/tracefs-utils.c b/src/tracefs-utils.c
index e10b333..9e37e75 100644
--- a/src/tracefs-utils.c
+++ b/src/tracefs-utils.c
@@ -15,6 +15,7 @@
#include <unistd.h>
#include <errno.h>
+#include <traceevent/event-parse.h>
#include <traceevent/event-utils.h>
#include "tracefs.h"
#include "tracefs-local.h"
@@ -25,12 +26,27 @@
#define _STR(x) #x
#define STR(x) _STR(x)
+static int log_level = TEP_LOG_CRITICAL;
+
+/**
+ * tracefs_set_loglevel - set log level of the library
+ * @level: desired level of the library messages
+ */
+void tracefs_set_loglevel(enum tep_loglevel level)
+{
+ log_level = level;
+ tep_set_loglevel(level);
+}
+
void __weak tracefs_warning(const char *fmt, ...)
{
va_list ap;
+ if (log_level < TEP_LOG_WARNING)
+ return;
+
va_start(ap, fmt);
- tep_vwarning("libtracefs", fmt, ap);
+ tep_vprint("libtracefs", TEP_LOG_WARNING, true, fmt, ap);
va_end(ap);
}
--
2.31.1
next prev parent reply other threads:[~2021-05-07 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:51 [PATCH v2 0/3] Add API to set severity to tracefs library logs Tzvetomir Stoyanov (VMware)
2021-05-07 9:51 ` Tzvetomir Stoyanov (VMware) [this message]
2021-05-07 9:51 ` [PATCH v2 2/3] libtracefs: Document new log functionality Tzvetomir Stoyanov (VMware)
2021-05-07 9:51 ` [PATCH v2 3/3] libtracefs: Remove dummy tep_vwarning() from unit tests Tzvetomir Stoyanov (VMware)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507095154.1080202-2-tz.stoyanov@gmail.com \
--to=tz.stoyanov@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).