From: Steven Rostedt <rostedt@goodmis.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: linux-trace-devel@vger.kernel.org,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Subject: Re: trace-cmd profile is not working
Date: Wed, 12 May 2021 09:55:41 -0400 [thread overview]
Message-ID: <20210512095541.4dcfdb4d@gandalf.local.home> (raw)
In-Reply-To: <8c1d353e-05d5-d789-00a2-de94d705950e@redhat.com>
On Wed, 12 May 2021 15:51:52 +0200
Jerome Marchand <jmarchan@redhat.com> wrote:
> Hi,
>
> Streams, and thus trace-cmd profile, are not working. A simple
> "trace-cmd profile ls" command exit with the following message
> "Creating stream for 0". I've been looking at it and the issue is that
> tracecmd_read_headers() tries to read the cmdlines, cpus and options
> sections that have not been written to the temporary file when called
> from trace_stream_init().
>
> AFAICT, it is caused by the two following patches:
>
> commit 1eea02a4 ("trace-cmd: Write saved cmdlines in the trace file at
> the end of the trace.") which moved the writing of cmdlines from
> create_file_fd() to tracecmd_create_file_latency() and
> tracecmd_append_cpu_data()
>
> commit 5d4d7ec3 ("trace-cmd: Move reading of trace.dat options to
> tracecmd_read_headers()") which moved the reading of options and cpu
> datas to tracecmd_read_headers().
>
Thanks for the report. I'm not surprised, profiling and streams have not
been given the love they deserve (been focusing on host/guest tracing
recently).
Can you fill out a bug report on bugzilla?
https://bugzilla.kernel.org/buglist.cgi?component=Trace-cmd%2FKernelshark&list_id=1090417&product=Tools&resolution=---
Thanks!
-- Steve
next prev parent reply other threads:[~2021-05-12 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 13:51 trace-cmd profile is not working Jerome Marchand
2021-05-12 13:55 ` Steven Rostedt [this message]
2021-05-12 14:09 ` Jerome Marchand
2021-05-12 15:15 ` Steven Rostedt
2021-05-14 7:56 ` Tzvetomir Stoyanov
2021-05-14 10:44 ` Jerome Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512095541.4dcfdb4d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=jmarchan@redhat.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).