From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: trace-cmd record: Update filter_command() to use tracefs_instance_file_append()
Date: Thu, 13 May 2021 17:03:22 -0400 [thread overview]
Message-ID: <20210513170322.5aa779d7@gandalf.local.home> (raw)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
Now that trace-cmd depends on libtracefs 1.2, have filter_command use the
tracefs_instance_file_append() as it had originally when first added,
instead of open coding it for libtracefs 1.1.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
tracecmd/trace-record.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c
index 5219d60b..ba9542ff 100644
--- a/tracecmd/trace-record.c
+++ b/tracecmd/trace-record.c
@@ -4556,20 +4556,7 @@ enum filter_type {
static int filter_command(struct tracefs_instance *instance, const char *cmd)
{
- char *path;
- int ret;
- int fd;
-
- path = tracefs_instance_get_file(instance, "set_ftrace_filter");
- if (!path)
- return -1;
- fd = open(path, O_WRONLY);
- tracefs_put_tracing_file(path);
- if (fd < 0)
- return -1;
- ret = write(fd, cmd, strlen(cmd));
- close(fd);
- return ret;
+ return tracefs_instance_file_append(instance, "set_ftrace_filter", cmd);
}
static int write_func_filter(enum filter_type type, struct buffer_instance *instance,
--
2.29.2
reply other threads:[~2021-05-13 21:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513170322.5aa779d7@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).