From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2 3/8] trace-cmd library: Add log levels
Date: Thu, 13 May 2021 23:19:00 -0400 [thread overview]
Message-ID: <20210513231900.4a7cfea2@oasis.local.home> (raw)
In-Reply-To: <CAPpZLN6+Tvdef-c6qgeg-f8RTpmAhxi5yy1am5FykyFVU4zTcA@mail.gmail.com>
On Fri, 14 May 2021 05:51:24 +0300
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> On Fri, May 14, 2021 at 12:23 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Fri, 7 May 2021 12:53:28 +0300
> > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com> wrote:
> >
> > > Removed the "weak" definition of the library log functions. Setting
> > > the desired log level can be used to silence the library logs, instead
> > > of overwriting the log functions.
> >
> > That's not the purpose of the weak definition. It is so that a GUI (like
> > kernelshark) can turn it into a pop up if need be or show in a status
> > window. It was not for quieting the function.
>
> The description is not correct. All these log functions use
> tep_vprint(), which is implemented as weak. This function has
> information for the library and log severity and should be used by
> kernelshark for that purpose. That's why I removed weak library
> specific functions.
Yes, tep_vprintk() could offer this as well, but there's still no
reason to not keep them as weak. Adding log levels is still unrelated
to removing the weak attribute.
I still do not see the rationale for removing the weak attribute of
these functions. It gives more flexibility for the users, without any
downsides.
Or is there a downside that you see for keeping them weak?
-- Steve
next prev parent reply other threads:[~2021-05-14 3:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:53 [PATCH v2 0/8] Changes to trace-cmd logs Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 1/8] trace-cmd library: Use tep_vprint() for logs Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 2/8] trace-cmd library: Add tracecmd_info() log function Tzvetomir Stoyanov (VMware)
2021-05-13 21:22 ` Steven Rostedt
2021-05-07 9:53 ` [PATCH v2 3/8] trace-cmd library: Add log levels Tzvetomir Stoyanov (VMware)
2021-05-13 21:23 ` Steven Rostedt
2021-05-14 2:51 ` Tzvetomir Stoyanov
2021-05-14 3:19 ` Steven Rostedt [this message]
2021-05-07 9:53 ` [PATCH v2 4/8] trace-cmd library: Document the API for " Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 5/8] trace-cmd library: Renamed tracecmd_fatal() to tracecmd_critical() Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 6/8] trace-cmd library: Set debug log level in debug mode Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 7/8] trace-cmd report: Set the log level with -V and -q options Tzvetomir Stoyanov (VMware)
2021-05-07 9:53 ` [PATCH v2 8/8] trace-cmd: Add new function to set log level Tzvetomir Stoyanov (VMware)
2021-05-13 21:36 ` Steven Rostedt
2021-05-14 2:53 ` Tzvetomir Stoyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513231900.4a7cfea2@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).