From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtraceevent: Add new line to trace-seq warnings
Date: Fri, 14 May 2021 09:38:58 -0400 [thread overview]
Message-ID: <20210514093858.4e862bda@gandalf.local.home> (raw)
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
The WARN_ONCE() logic in trace_seq is based off of the WARN_ONCE() logic
in the Linux kernel, where the message does not require to end with a new
line. But the implementation is different than the kernel, and it lacks
adding a new line when it writes the output.
Add the new line to make it match what happens in the Linux kernel.
Link: https://lore.kernel.org/linux-trace-devel/20210514122825.162203-1-y.karadz@gmail.com/
Fixes: 3b760f95 ("tools include: Move perf's bug.h to a generic place")
Reported-by: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
include/asm/bug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm/bug.h b/include/asm/bug.h
index 550223f..de8f8fe 100644
--- a/include/asm/bug.h
+++ b/include/asm/bug.h
@@ -5,7 +5,7 @@
#include <linux/compiler.h>
#include <stdio.h>
-#define __WARN_printf(arg...) do { fprintf(stderr, arg); } while (0)
+#define __WARN_printf(arg...) do { fprintf(stderr, arg); fprintf(stderr, "\n");} while (0)
#define WARN(condition, format...) ({ \
int __ret_warn_on = !!(condition); \
--
2.29.2
reply other threads:[~2021-05-14 13:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210514093858.4e862bda@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).