Re: [PATCH] trace-cmd: Add option to poll trace buffers

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 2 Jun 2021 10:05:42 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed,  2 Jun 2021 11:08:03 +0200
> Nicolas Saenz Julienne <nsaenzju@redhat.com> wrote:
> 
> > NOTE: I'm aware that TRACECMD_RECORD_POLL kind of clashes with
> >       TRACECMD_RECORD_BLOCK. That's why I renamed it. There might be a
> >       clean way to merge them into a single flag, but it's not clear to
> >       me why was TRACECMD_RECORD_BLOCK needed in the first place (since
> >       it only affects splicing).  
> 
> Yeah that was poorly named, and was added when streaming was added (not
> recording to a file, but to simply read from splice). I don't remember
> exactly all that happened back them, but you are correct, it can
> probably be better organized.
> 
> Thanks for sending the patch, I'll have a look at it this week.

FYI, I pushed this patch up to the git repo.

Thanks,

-- Steve