From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0DEC07E95 for ; Wed, 7 Jul 2021 13:47:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABDAA61C9A for ; Wed, 7 Jul 2021 13:47:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231357AbhGGNuS (ORCPT ); Wed, 7 Jul 2021 09:50:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:37328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbhGGNuS (ORCPT ); Wed, 7 Jul 2021 09:50:18 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3AD361C89; Wed, 7 Jul 2021 13:47:37 +0000 (UTC) Date: Wed, 7 Jul 2021 09:47:30 -0400 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH] libtracefs: Fix bug in tracefs_instances() Message-ID: <20210707094730.7781eea9@oasis.local.home> In-Reply-To: <20210707130523.67268-1-y.karadz@gmail.com> References: <20210707130523.67268-1-y.karadz@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Wed, 7 Jul 2021 16:05:23 +0300 "Yordan Karadzhov (VMware)" wrote: > The empty string is now made of two elements, because of the hidden > first element that stores its size. > > Fixes: 056a177 (libtracefs: Restructure how string lists work) > Signed-off-by: Yordan Karadzhov (VMware) > --- > src/tracefs-instance.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c > index 11fb580..d601db2 100644 > --- a/src/tracefs-instance.c > +++ b/src/tracefs-instance.c > @@ -694,7 +694,7 @@ char **tracefs_instances(const char *regex) > } else { > /* No matches should produce an empty list */ > if (!list.list) > - list.list = calloc(1, sizeof(*list.list)); > + list.list = trace_list_create_empty(); > } > return list.list; > } Thanks! I guess I missed one :-p -- Steve