linux-trace-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 3/4] trace-cruncher: Allow for detachable instances
Date: Thu, 22 Jul 2021 17:19:30 -0400	[thread overview]
Message-ID: <20210722171930.608c8926@oasis.local.home> (raw)
In-Reply-To: <20210712123242.223500-3-y.karadz@gmail.com>

On Mon, 12 Jul 2021 15:32:41 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:

> @@ -600,6 +610,11 @@ PyObject *PyFtrace_create_instance(PyObject *self, PyObject *args,
>  	}
>  
>  	iw->ptr = instance;
> +	if (detached) {
> +		printf("detached instance: %s\n", name);

Do we really need to print this? I would think this is up to the
calling function to print this or not.

-- Steve


> +		iw->detached = detached;
> +	}
> +

  reply	other threads:[~2021-07-22 21:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 12:32 [PATCH 1/4] trace-cruncher: Add set_ftrace_loglevel() Yordan Karadzhov (VMware)
2021-07-12 12:32 ` [PATCH 2/4] trace-cruncher: Add local_tep() to utils Yordan Karadzhov (VMware)
2021-07-12 12:32 ` [PATCH 3/4] trace-cruncher: Allow for detachable instances Yordan Karadzhov (VMware)
2021-07-22 21:19   ` Steven Rostedt [this message]
2021-07-26  9:04     ` Yordan Karadzhov (VMware)
2021-07-26 13:48       ` Steven Rostedt
2021-07-12 12:32 ` [PATCH 4/4] trace-cruncher: Allow for detachable kprobes Yordan Karadzhov (VMware)
2021-07-22 21:24   ` Steven Rostedt
     [not found]     ` <cb908dc6-9ca8-7962-723a-a2388cebaf82@gmail.com>
2021-07-29 10:25       ` Yordan Karadzhov
2021-07-22 21:15 ` [PATCH 1/4] trace-cruncher: Add set_ftrace_loglevel() Steven Rostedt
2021-07-26  9:34   ` Yordan Karadzhov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210722171930.608c8926@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).