From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] kernel-shark: Treat all tracing headers as library headers
Date: Mon, 26 Jul 2021 09:59:25 -0400 [thread overview]
Message-ID: <20210726095925.184b3826@oasis.local.home> (raw)
In-Reply-To: <20210726094141.191579-2-y.karadz@gmail.com>
On Mon, 26 Jul 2021 12:41:41 +0300
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> 1. Note that this patch actually fixes a build failure, caused by the
> following commit in libtracefs:
> 880885d (libtracefs: Remove "traceevent/" from referencing libtraceevent headers)
> It seems that so far the discovery of the headers was working more or
> less by chance.
Yep, it was "by chance", that we just happened to include the headers
in the main directory in the same paths as were added in the files. But
if we ever changed those paths, the files would not be updated and the
compile would break.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
to both patches.
Thanks Yordan.
-- Steve
prev parent reply other threads:[~2021-07-26 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 9:41 [PATCH 1/2] kernel-shark: Cleanup in CMakeLists.txt Yordan Karadzhov (VMware)
2021-07-26 9:41 ` [PATCH 2/2] kernel-shark: Treat all tracing headers as library headers Yordan Karadzhov (VMware)
2021-07-26 13:59 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726095925.184b3826@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).