From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F39C4338F for ; Wed, 4 Aug 2021 00:51:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B192860EE8 for ; Wed, 4 Aug 2021 00:51:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230438AbhHDAvb (ORCPT ); Tue, 3 Aug 2021 20:51:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54322 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbhHDAv3 (ORCPT ); Tue, 3 Aug 2021 20:51:29 -0400 Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B779160E96; Wed, 4 Aug 2021 00:51:15 +0000 (UTC) Date: Tue, 3 Aug 2021 20:51:14 -0400 From: Steven Rostedt To: Ian Rogers Cc: linux-trace-devel@vger.kernel.org, Tzvetomir Stoyanov , Claire Jensen Subject: Re: [PATCH 2/2] libtracefs: Silence sometimes-uninitialized warning Message-ID: <20210803205114.24edfe8c@rorschach.local.home> In-Reply-To: <20210804004109.1476661-2-irogers@google.com> References: <20210804004109.1476661-1-irogers@google.com> <20210804004109.1476661-2-irogers@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Tue, 3 Aug 2021 17:41:09 -0700 Ian Rogers wrote: > Warning generated by clang: > > src/tracefs-events.c:1046:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] > if (!systems) > ^~~~~~~~ > src/tracefs-events.c:1101:9: note: uninitialized use occurs here > return ret; > ^~~ > src/tracefs-events.c:1046:2: note: remove the 'if' if its condition is always false > if (!systems) > ^~~~~~~~~~~~~ > src/tracefs-events.c:1038:9: note: initialize the variable 'ret' to silence this warning > int ret; > ^ > = 0 That's a legitimate path to have ret returned without being initialized. I'll add both patches to my next push. Thanks! -- Steve > > Signed-off-by: Ian Rogers > --- > src/tracefs-events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/tracefs-events.c b/src/tracefs-events.c > index 8d84838..4679926 100644 > --- a/src/tracefs-events.c > +++ b/src/tracefs-events.c > @@ -1035,7 +1035,7 @@ static int event_enable_disable(struct tracefs_instance *instance, > regex_t system_re, event_re; > char **systems; > char **events = NULL; > - int ret; > + int ret = -1; > int s, e; > > /* Handle all events first */